932533 - Add a flag, "active", to Functional Areas

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

We'd like to update the list of functional areas (bug 918546), but don't want to delete any of them since they are important relational data. So we need to mark some of our current functional areas as inactive. Let's add a flag for that.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/9f19ba1e9e1c6475b46d53202ec9661281af7f37
[Fix Bug 932533] Add active flag to Functional Areas

Comment 2

[William Reynolds [:williamr]]

Verified that Functional Areas now have an "active" flag, which can be set in the admin panel. When adding Functional Areas to a report or event, only active Functional Areas are viewable and selectable as expected. Any entries that use inactive Functional Areas still have that data, but those inactive Functional Areas are not displayed in the UI. So no data has been deleted, and we only display information about active Functional Areas.

Thanks for adding this flag, nemo!

Comment 3

[William Reynolds [:williamr]]

I should say...thanks for adding this flag, hardfire!!

Comment 4

[Giorgos Logiotatidis [:giorgos]]

I'm reopening this bug to change the current behavior:
 1. We keep the inactive flag
 2. We do not filter inactive categories out by default
 3. We only filter out inactive areas when users are about to create a new event or ngreport or anywhere else that they pick areas except their profile.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/29a37afe3e61e87c745eca72ab6f67777c0f18c3
[Fix bug 932533] Revert to default FunctionalArea object manager.

* Preserve inactive areas in Events/NGReports.
* Enable searching on both active and inactive areas.

https://github.com/mozilla/remo/commit/d070316a61c3b77af6947904289395744ffb08e6
Merge pull request #642 from johngian/932533-active-areas

[Fix bug 932533] Revert to default Functional Areas object manager.

Comment 6

[Tasos Katsoulas [:tasos]]

Verified on stage.

Steps:
* Inactive functional areas are now editable through the settings page in the portal.
* Users can select/edit inactive functional areas in an already saved event, if these functional areas were active and selected as event categories during the creation of the event.
* Users cannot select inactive functional areas for a new event.
* The above apply for the reports too.