Closed Bug 932607 Opened 12 years ago Closed 12 years ago

[l10n][1.2] Macedonian Keyboard Missing

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- verified

People

(Reporter: delphine, Assigned: gdamjan)

References

Details

(Whiteboard: LocRun1.2)

Attachments

(1 file)

github pull request
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
Seems like the Macedonian keyboard is missing on 1.2, although it's a shipping locale Seen on Buri device, 1.2 Com RIl Gaia 2ef9bc3c7a6de228b63e6ba3613eb0c0dd639c59 SourceStamp 4a94d2ea9d37 BuildID 20131028004002 Version 26.0a2 Marking as koi? since Macedonian is a 1.2 requested locale
blocking-b2g: --- → koi?
Flags: needinfo?(rlu)
Depends on: 884752
Assignee: nobody → rlu
Flags: needinfo?(rlu)
Shipping locale.
blocking-b2g: koi? → koi+
(In reply to Damjan Georgievski from comment #2) > I've submitted one here > https://bugzilla.mozilla.org/show_bug.cgi?id=924464 Damjan, that's a great news! Could you rebase your work against latest master and submit a pull request?
Flags: needinfo?(gdamjan)
Here's the pull request https://github.com/mozilla-b2g/gaia/pull/12796
Flags: needinfo?(gdamjan)
Also there's a pull request for branch v1.2 https://github.com/mozilla-b2g/gaia/pull/12794
(In reply to Damjan Georgievski from comment #5) > Here's the pull request > https://github.com/mozilla-b2g/gaia/pull/12796 Damjan, thank you very very much. However, please submit the pull request as described here: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Gaia/Hacking#Submitting_a_patch May I ask if the Macedonian language should come with a spell checker dictionary? If not this patch is good to go (except for the process needed and the commit message). (In reply to Damjan Georgievski from comment #6) > Also there's a pull request for branch v1.2 > https://github.com/mozilla-b2g/gaia/pull/12794 You don't need to file a separate pull request to v1.2 unless the code is complex and require a different patch. We will cherry-pick the patch.
Assignee: rlu → gdamjan
Please read the comment above. Thanks!
Flags: needinfo?(gdamjan)
Attached file github pull request —
Attached pull request. For now we don't have a dictionary
Attachment #826016 - Flags: review?(timdream)
Flags: needinfo?(gdamjan)
Comment on attachment 826016 [details] [review] github pull request The keyboard layout itself looks good. Thanks! I am not sure if missing dictionary makes this bug incomplete, if we have a dictionary we should file another bug to commit it.
Attachment #826016 - Flags: review?(timdream) → review+
master: https://github.com/mozilla-b2g/gaia/commit/50f0c914fa5cb89694c0cdd41b6e10b714787070
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Bruce, Delphine, do we know if we absolutely need a spell check / word completion to say the language is complete?
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(bhuang)
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1.2 git cherry-pick -x -m1 50f0c914fa5cb89694c0cdd41b6e10b714787070 <RESOLVE MERGE CONFLICTS> git commit
Flags: needinfo?(gdamjan)
what does "uplift" mean? Also, Tim Guan-tin Chien said I shouldn't add the v1.2 branch. So which one is it?
Flags: needinfo?(timdream)
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(jhford)
Flags: needinfo?(gdamjan)
Flags: needinfo?(bhuang)
(In reply to Damjan Georgievski from comment #14) > what does "uplift" mean? > > Also, Tim Guan-tin Chien said I shouldn't add the v1.2 branch. So which one > is it? Uplift is what we call the process of getting changes from master branch to the v1.2 (et al) branch. This bug is koi+ as of comment 1, so it looks like this is desired on v1.2 and will be uplifted.
Flags: needinfo?(jhford)
(In reply to Damjan Georgievski from comment #14) > what does "uplift" mean? > > Also, Tim Guan-tin Chien said I shouldn't add the v1.2 branch. So which one > is it? Damjan, I was saying that the "uplift" process will happen semi-automatically by cheery-picking your patch from master patch, so you don't really have to spend time creating a pull request to v1.2. ... and yes, I expect this to be uplifted soon.
Flags: needinfo?(timdream)
On wait, comment 13 said this cannot be semi-automatically uplifted, so you *do* need to manually create a pull request. Sorry for the confusion. I will just going to import your commit https://github.com/gdamjan/gaia/commit/27b7d62b1a6b5012ab74fa006f1935aa203603cd from https://github.com/mozilla-b2g/gaia/pull/12794 and push that to v1.2 branch.
The keyboard is still missing on Buri 1.2 commercial RIL Build ID: 20131107004003 Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/26f1e160e696 Gaia: 590eb598aacf1e2136b2b6aca5c3124557a365ca Platform Version: 26.0 RIL Version: 01.01.00.019.281
Flagging David as it seems it's still missing on today's build thanks!
Flags: needinfo?(dflanagan)
Delphine: I don't know anything about how the builds get created. Whoever creates the builds has to list the desired keyboard layouts to go into the build. Now that there is a new layout available, presumably someone's build script must be updated. Also, I just saw a patch from Axel that corrects the Macedonian layout to remove the reference to the non-existent autocorrect dictionary. So the layout file is there. I'll pass the needinfo on to Axel.
Flags: needinfo?(dflanagan) → needinfo?(l10n)
We'll need the patch to make the mk actually build, that's in bug 938052. We should have an autocomplete dictionary for an official language, I suggest that we get a new bug for that. I'm not sure if we have the chance to include keyboards for all the 1.2 languages in the buri build. I know next to nothing about how/who/when/what does them, but their automation might want to explicitly state which keyboards it wants, next to the language list specification.
Flags: needinfo?(l10n)
Just uplifted the patch for bug 938052 to v1.2, please try again to verify this issue. Please make sure you have mk included when building Gaia, e.g. > GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,pl,mk make reset-gaia Thanks.
The keyboard is shown and works however there is no autocorrect present
Environmental Variables Device: Buri v1.2 COM RIL Build ID: 20131202004001 Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/14868788d50e Gaia: 075e60c878b0eca68fba9e00bc85cb6eac03578a/A Platform Version: 26.0 RIL Version: 01.02.00.019.102 Firmware Version: v1.2_20131115
Well. this one is marked as FIXED but I don't see it in the latest Keon 1.2 build I got (right now). Btw. this version says 1.2.0.0-prerelease and build identificator of "20131226225031" but has no git commit in About - More info...
(In reply to Damjan Georgievski from comment #26) > Well. this one is marked as FIXED but I don't see it in the latest Keon 1.2 > build I got (right now). > > Btw. this version says 1.2.0.0-prerelease and build identificator of > "20131226225031" but has no git commit in About - More info... That could be a Geeksphone problem (build script that needs to be updated). I suggest filing a bug in Firefox OS-General and CCing Geeksphone to it.
Or post it on their forums.
Verified the Macedonian keyboard appears after customizing the GAIA_KEYBOARD_LAYOUTS environment variable. Device: Buri 1.2 MOZ BuildID: 20140102004001 Gaia: Gecko: 0c11156c7d9b Version: 26.0
Status: RESOLVED → VERIFIED
status-b2g-v1.2: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: