932651 - [e10s] getClipboardData in specialpowersAPI not e10s friendly

Status: VERIFIED FIXED

(Testing :: Mochitest, defect)

Description

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

getClipboardData does 'this._getDocShell(content.window)' - this doesn't work in e10s for 2 reasons:

* content.window may not exist yet - it is setup asynchronously - eg, browser_bug556061.js hits this.

* Even if content.window was setup, there's no docShell for it (the docShell is in the content process)

Comment 1

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Attachment: 0002-Bug-932651-getClipboardData-in-specialpowersAPI-uses.patch

Now that the password manager is e10s friendly, attempting to enable those tests hit this clipboard problem.  A simple fix to the clipboard problem is to use the chrome window rather than the content window, and doing this allows all the password manager tests to pass under e10s, as well as the 2 tests disabled due to this bug (well, nearly - one of those other tests now hits a different issue, which I've recorded in browser.ini)

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8492007 [details] [diff] [review]
0002-Bug-932651-getClipboardData-in-specialpowersAPI-uses.patch

Review of attachment 8492007 [details] [diff] [review]:
-----------------------------------------------------------------

I can't say I understand the mechanics of why it works, but it's fine with me.

Comment 3

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

I ended up pushing a slightly modified version of the patch due to failures on try - the relevant part of SpecialPowers pushed was:

-    xferable.init(this._getDocShell(content.window)
+    // in e10s b-c tests |content.window| is null whereas |window| works fine.
+    // for some non-e10s mochi tests, |window| is null whereas |content.window|
+    // works fine.  So we take whatever is non-null!
+    xferable.init(this._getDocShell(content.window || window)

Which I figured was close enough to the original intent I didn't re-request review.  Try at https://tbpl.mozilla.org/?tree=Try&rev=cd2b8f931de2

https://hg.mozilla.org/integration/fx-team/rev/5be05e3aa09c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5be05e3aa09c