Closed
Bug 932821
Opened 13 years ago
Closed 12 years ago
Android panda mozharness script calls _install_app() unnecessarily for cpp unittests and jit-tests
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dminor, Assigned: dminor)
Details
Attachments
(1 file)
|
1.70 KB,
patch
|
kmoir
:
review+
|
Details | Diff | Splinter Review |
These two harnesses do not require the browser to be installed on the test device, so this ends up wasting time and sdcard writes.
|
Assignee | |
Comment 1•13 years ago
|
||
I've followed the existing if structure which uses:
if 'test' in suite:
Based on reading the code, I think the intention is:
if suite.startswith('test'):
If so, I think using startswith would be clearer and I can update the patch accordingly. Using 'in' makes me expect a list, not a string.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 825290 [details] [diff] [review]
Disable _install_app for cpp and jit-tests
tested in staging while I was testing other patches today
Attachment #825290 -
Flags: review?(kmoir) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
This was accidentally pushed to production and has stuck, so closing now.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Component: General Automation → Mozharness
You need to log in
before you can comment on or make changes to this bug.
Description
•