Closed
Bug 932830
Opened 12 years ago
Closed 12 years ago
Add home banner API to let add-on know when message is shown to user
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec28+)
RESOLVED
FIXED
Firefox 28
| Tracking | Status | |
|---|---|---|
| fennec | 28+ | --- |
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
Similarly to setting an onclick handler, an add-on should also be able to set an onshown handler.
This will be important for metrics for the snippets add-on.
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #824888 -
Flags: review?(wjohnston)
Updated•12 years ago
|
tracking-fennec: ? → 28+
Comment 2•12 years ago
|
||
Comment on attachment 824888 [details] [diff] [review]
patch
Review of attachment 824888 [details] [diff] [review]:
-----------------------------------------------------------------
I'd rather "onshown" than "onshow". We should write some tests for this :)
Attachment #824888 -
Flags: review?(wjohnston) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c7bf717e72b1
Updated the docs here:
https://developer.mozilla.org/en-US/docs/Extensions/Mobile/API/Home.jsm
And I filed bug 934678 about getting some tests.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•