Closed
Bug 932963
Opened 11 years ago
Closed 11 years ago
Break customize mode transition into several phases
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: perf, Whiteboard: [Australis:P2][Australis:M9])
Attachments
(1 file, 4 obsolete files)
|
11.80 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
bwinton and I were looking at some reflow profiles, and we think we might be able to optimize the customize mode transition if we disable some styles while transitioning in and out.
We're proposing to break the customize mode transition into several phases:
Entering:
Phase 0: Pre-transition
Phase 1: Transitioning (CSS optimized)
Phase 2: Transitioned / In Customize mode (full-on CSS prettiness)
Exiting would be symmetrical.
|
Assignee | |
Comment 1•11 years ago
|
||
Ok, I'm going to try to make this happen.
Assignee: nobody → mconley
|
|
Assignee | |
Comment 2•11 years ago
|
||
This seems to do the job for OS X. Moving on to Windows next...
|
|
Assignee | |
Comment 3•11 years ago
|
||
Seems to work OK with Windows, but I'll want to go over all of these rules again before I ask for review...
Attachment #828274 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•11 years ago
|
||
Ok, time to go over this CSS with a fine tooth comb...
Attachment #828318 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
Final testing pass, and then I'll ask for review...
Attachment #828321 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•11 years ago
|
||
Real patch this time...
Attachment #828352 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 828354 [details] [diff] [review]
Patch v1.1
Hey Jared, how does this look to you?
Attachment #828354 -
Flags: review?(jaws)
|
||
Comment 8•11 years ago
|
||
Comment on attachment 828354 [details] [diff] [review]
Patch v1.1
Review of attachment 828354 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, this looks good. I think it did improve the smoothness of exiting customization mode.
::: browser/components/customizableui/src/CustomizeMode.jsm
@@ +300,5 @@
> + * Exiting customization mode has a similar set of phases, but in reverse
> + * order - customize-entered, customize-exiting, pre-customization mode.
> + *
> + * When in the customize-entering, customize-entered, or customize-exiting
> + * phases, there is a "customize" attribute set on the main-window to simplify
s/"customize"/"customizing"/
Attachment #828354 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Thanks! Landed with s/"customize"/"customizing" on UX as
https://hg.mozilla.org/projects/ux/rev/9f6d6fa60cf0
Status: NEW → ASSIGNED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux]
|
||
Comment 10•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux] → [Australis:P2][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•