Closed Bug 932963 Opened 11 years ago Closed 11 years ago

Break customize mode transition into several phases

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Keywords: perf, Whiteboard: [Australis:P2][Australis:M9])

Attachments

(1 file, 4 obsolete files)

bwinton and I were looking at some reflow profiles, and we think we might be able to optimize the customize mode transition if we disable some styles while transitioning in and out.

We're proposing to break the customize mode transition into several phases:

Entering:

Phase 0: Pre-transition
Phase 1: Transitioning (CSS optimized)
Phase 2: Transitioned / In Customize mode (full-on CSS prettiness)

Exiting would be symmetrical.
Blocks: 933926
Blocks: 933961
Ok, I'm going to try to make this happen.
Assignee: nobody → mconley
Attached patch WIP Patch 1 (obsolete) — Splinter Review
This seems to do the job for OS X. Moving on to Windows next...
Attached patch WIP Patch 2 (obsolete) — Splinter Review
Seems to work OK with Windows, but I'll want to go over all of these rules again before I ask for review...
Attachment #828274 - Attachment is obsolete: true
Attached patch Patch v1 (obsolete) — Splinter Review
Ok, time to go over this CSS with a fine tooth comb...
Attachment #828318 - Attachment is obsolete: true
Attached patch Patch v1.1 (obsolete) — Splinter Review
Final testing pass, and then I'll ask for review...
Attachment #828321 - Attachment is obsolete: true
Attached patch Patch v1.1Splinter Review
Real patch this time...
Attachment #828352 - Attachment is obsolete: true
Comment on attachment 828354 [details] [diff] [review]
Patch v1.1

Hey Jared, how does this look to you?
Attachment #828354 - Flags: review?(jaws)
Comment on attachment 828354 [details] [diff] [review]
Patch v1.1

Review of attachment 828354 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this looks good. I think it did improve the smoothness of exiting customization mode.

::: browser/components/customizableui/src/CustomizeMode.jsm
@@ +300,5 @@
> +   * Exiting customization mode has a similar set of phases, but in reverse
> +   * order - customize-entered, customize-exiting, pre-customization mode.
> +   *
> +   * When in the customize-entering, customize-entered, or customize-exiting
> +   * phases, there is a "customize" attribute set on the main-window to simplify

s/"customize"/"customizing"/
Attachment #828354 - Flags: review?(jaws) → review+
Thanks! Landed with s/"customize"/"customizing" on UX as

https://hg.mozilla.org/projects/ux/rev/9f6d6fa60cf0
Status: NEW → ASSIGNED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/9f6d6fa60cf0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux] → [Australis:P2][Australis:M9]
Target Milestone: --- → Firefox 28
Depends on: 963576
You need to log in before you can comment on or make changes to this bug.