932969 - Find bar string is "undefined" upon first invocation

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

STR: Hit Ctrl+F in recent SM trunk build

Result: "undefined"

Expected: "" (empty string) / "Find in page" placeholder text

Comment 1

[Philip Chee]

Probably due to the refactoring by Firefox developers when making one findbar per tab instead of sharing one findbar per tabbrowser.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[[e-mail]]

Stupid Bugzilla.

Comment 5

[[e-mail]]

Comment on attachment 825453 [details] [diff] [review]
Proposed patch

Bug 916477 overlooked an subtle part of the finder code. Because we share the findbar between all the tabs we also need the last search cache fields defined on the tabbrowser rather than the browser.

If you don't want to do the review and Ratty hasn't finished rebuilding his laptop yet then feel free to punt it to IanN or someone.

Comment 6

[Philip Chee]

Setting reminder to myself
If needed: rs=me from code inspection.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 825453 [details] [diff] [review]
Proposed patch

FTR: I actually tried and analyzed this. Thanks Ratty anyway, maybe another time I'll accept your offer. :-)

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Neil, are you waiting for the tree to reopen or can this land?

Comment 9

[Philip Chee]

Comment on attachment 825453 [details] [diff] [review]
Proposed patch

This patch works for me.

Comment 10

[[e-mail]]

Pushed comm-central changeset ff1d24951bcc.