Closed
Bug 933010
Opened 11 years ago
Closed 11 years ago
AsyncErrorReporter should take boolean principal argument
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: nsm, Assigned: nsm)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
4.49 KB,
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
It is used only to determine what category to show the error under in the error console (system principal or not). Getting the principal on workers is circuitous, requiring main thread access, but it is easy to check if the worker uses the system principal or not.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #824932 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nsm.nikhil
|
||
Comment 2•11 years ago
|
||
Comment on attachment 824932 [details] [diff] [review]
AsyncErrorReporter takes bool isSystemPrincipal.
Please fix the commit message to match the actual variable name?
> ScriptErrorEvent(nsIScriptGlobalObject* aScriptGlobal,
This should keep taking a principal, but pass through nsContentUtils::IsSystemPrincipal(aGlobalPrincipal), no? Right now you're ending up with callers passing a principal but it getting coerced to bool, so they all look like chrome...
r=me with that fixed.
Attachment #824932 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #824932 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #824971 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•