933015 - Scratch "undo" and "redo" menus are completely broken

Status: VERIFIED FIXED

(DevTools Graveyard :: Scratchpad, defect, P1)

Description

[Brandon Benvie [:benvie]]

The keybindings for undo and redo work just fine, but if you press the menu items they act unpredictably (usually not at all). This likely has to do with the switch to CodeMirror.

Comment 1

[Anton Kovalyov (:anton)]

It seems like Editor's custom controller doesn't get called through the goDoCommand. I'm not sure why yet. I can see supportsCommand being called and returning true but that's about it.

Comment 2

[Anton Kovalyov (:anton)]

Attachment: WIP 1

This patch attaches controller to the hidden text area. It also removes cmd_cut and cmd_paste from the controller since we don't really need them there *and* they trigger an infinite recursion error which was hidden because of this very bug. :)

Comment 3

[Anton Kovalyov (:anton)]

We will need to uplift this patch to Aurora once its reviewed and in Nightly.

Comment 4

[Brandon Benvie [:benvie]]

Comment on attachment 827100 [details] [diff] [review]
WIP 1

Review of attachment 827100 [details] [diff] [review]:
-----------------------------------------------------------------

This all looks straightforward, although I might not be qualified to pass judgement on editor stuff since I haven't worked with it. I suppose you're the main person who's worked on it, besides Optimizer. LGTM though!

Comment 5

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/99497e0ef81e

Comment 6

[Anton Kovalyov (:anton)]

Comment on attachment 827100 [details] [diff] [review]
WIP 1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 912260
User impact if declined: undo/redo buttons won't work in Scratchpad
Testing completed (on m-c, etc.): fx-team, m-c after fx-team to m-c merge, local
Risk to taking this patch (and alternatives if risky): Low risk. Code didn't change much.
String or IDL/UUID changes made by this patch: N/A

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/99497e0ef81e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9b4b4c1b6dfe

Comment 9

[Bogdan Maris, Desktop QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0

Verified as fixed on latest Aurora (buildID: 20131107004005) and latest Nightly (buildID: 20131107030200).