933071 - require a --with-private-frameworks-path when cross-compiling for OS X

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

We need this for libxul so we don't need /System/Library/PrivateFrameworks on the compile host machine; ideally we can inject it into webrtc too.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add --with-macos-private-frameworks to support cross-compiling

With this flag, I can get libxul to link.  The widget/cocoa changes are a drive-by, but
they appear totally unused in the current build configuration.

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 825293 [details] [diff] [review]
add --with-macos-private-frameworks to support cross-compiling

This makes configure fail when run on Linux:

configure: error: PrivateFrameworks directory not found.
*** Fix above errors and then restart with               "make -f client.mk build"
make: *** [configure] Error 1

I guess it needs to go inside a check for OSX builds? Not sure the best way to do that.

Also I think you can do the default argument like this:

MOZ_ARG_WITH_STRING(macos-private-frameworks,
[  --with-macos-private-frameworks=dir    Location of private frameworks to use (Mac OS X only)],
    MACOS_PRIVATE_FRAMEWORKS_DIR=$withval,
    MACOS_PRIVATE_FRAMEWORKS_DIR=/System/Library/PrivateFrameworks)

So you don't need the _DEFAULT variable and such.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 825293 [details] [diff] [review]
> add --with-macos-private-frameworks to support cross-compiling
> 
> This makes configure fail when run on Linux:
> 
> configure: error: PrivateFrameworks directory not found.
> *** Fix above errors and then restart with               "make -f client.mk
> build"
> make: *** [configure] Error 1
> 
> I guess it needs to go inside a check for OSX builds? Not sure the best way
> to do that.

Oh, hm.  I guess maybe the checks should be guarded by whether we have a MacOS SDK to compile against.

> Also I think you can do the default argument like this:
> 
> MOZ_ARG_WITH_STRING(macos-private-frameworks,
> [  --with-macos-private-frameworks=dir    Location of private frameworks to
> use (Mac OS X only)],
>     MACOS_PRIVATE_FRAMEWORKS_DIR=$withval,
>     MACOS_PRIVATE_FRAMEWORKS_DIR=/System/Library/PrivateFrameworks)
> 
> So you don't need the _DEFAULT variable and such.

Mm, good to know!  I was keeping the _DEFAULT variable so configure could complain at people who set it to something weird and weren't cross-compiling.

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: add --with-macos-private-frameworks to support cross-compiling

Here's a revised version that seems to pass smoketesting on Linux.

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: add --with-macos-private-frameworks to support cross-compiling

Actually, let's fix the WebRTC case, too, since that's definitely under our control.

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 825380 [details] [diff] [review]
add --with-macos-private-frameworks to support cross-compiling

This looks good to me now!

Comment 7

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c8d23cfa1d8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c8d23cfa1d8