933113 - Needs a new mechanism for pairing with another Bluetooth device when apps have Bluetooth device address

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Eric Chou [:ericchou] [:echou]]

In the discussion of NFC workweek, we need a new mechanism or a new API to pair with remote devices by their Bluetooth device address. A BluetoothDevice object is necessary for pairing, but Gaia apps aren't able to get one except through event DeviceFound or function GetPairedDevices().

Comment 1

[Eric Chou [:ericchou] [:echou]]

Per offline discussion with Gina and Ben, we decided to change the parameter of Pair/Unpair, replacing BluetoothDevice with Bluetooth device address(DOMString). Will start to work on it tomorrow.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: modify Pair/Unpair interface for Gaia to be able to Pair/Unpair with BD_Address

NFC handover is a mechanism for two devices to exchange their Bluetooth device address with each other. Then one device would be initialize the Bluetooth pairing process with received Bluetooth device address. However currently we need a BluetoothDevice object for Pairing/Unpairing, but actually the address of the Bluetooth device object is the only thing Gecko requires.

sr? mrbkap since the patch changes the Pair/Unpair API.

Settings app is the only one using these two APIs so the revision must be necessary. The followup is bug 938472.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Nominate as 1.3+ since it blocks 1.3+ bug 903305.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v2: modify Pair/Unpair interface for Gaia to be able to Pair/Unpair with BD_Address

* Patch updated because I forgot removing comments.

Comment 5

[Ken Chang[:kenkai]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #3)
> Nominate as 1.3+ since it blocks 1.3+ bug 903305.
It is 1.3+.

Comment 6

[Ken Chang[:kenkai]]

And set target milestone.

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 832050 [details] [diff] [review]
patch 1: v2: modify Pair/Unpair interface for Gaia to be able to Pair/Unpair with BD_Address

Review of attachment 832050 [details] [diff] [review]:
-----------------------------------------------------------------

I think it should be fine to change the parameter of Pair/Unpari from a BluetoothDevice to device address.

Comment 8

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=11820bbb9c2f

Comment 9

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b14b67c82e4d

Thank you both. :)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b14b67c82e4d