933487 - [traceback] ValueError: invalid literal for int() with base 10: 'meow' by fuzzing ?page= param for /exploitability

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

Load https://crash-stats.allizom.org/report/exploitability/?page=meow

Actual:

ValueError: invalid literal for int() with base 10: 'meow'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/decorators.py", line 48, in inner
    return view(request, *args, **kwargs)
  File "django/contrib/auth/decorators.py", line 20, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "crashstats/crashstats/views.py", line 838, in exploitable_crashes
    page = max(1, int(request.GET.get('page', 1)))

Errormill: https://errormill.mozilla.org/webtools/socorro-stage/group/126887/

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: Github PR

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c59ce6da8321a52de4bd971dd67e1a3ab53d87ad
fixes bug 933487 - fuzzing ?page param for /exploitability, r=rhelmer

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx Peter; verified fixed on https://crash-stats.allizom.org/report/exploitability/?page=meow

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot