Closed
Bug 933808
Opened 11 years ago
Closed 11 years ago
Add tests for AccessFu TraversalRules.
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla28
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | fixed |
People
(Reporter: MarcoZ, Assigned: maxli)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
10.05 KB,
patch
|
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
The tests should throw different accessibles at the traversal rules and make sure the markup is covering all the possible scenarios. Of course, future bugs will introduce new markup, but this should lay the foundation for these tests.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8339236 -
Flags: review?(marco.zehe)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8339236 [details] [diff] [review]
Patch
Nice! r=me with one nit:
>+ <a target="_blank"
>+ title=""
>+ href="https://bugzilla.mozilla.org/show_bug.cgi?id=933808">Mozilla Bug 933808</a>
You forgot to fill in the title string. :-)
Thanks for this, Max!
|
|
Assignee | |
Comment 3•11 years ago
|
||
Assignee: nobody → maxli
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 8339236 [details] [diff] [review]
Patch
Whoops, had given a verbal r+, but forgot to mark the patch as such. Sorry about that!
Attachment #8339236 -
Flags: review?(marco.zehe) → review+
|
||
Updated•11 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•