933943 - TypeError: n[0] is undefined

Status: VERIFIED FIXED

(Marketplace Graveyard :: Statistics, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Log into a non-admin account on marketplace
2. Load https://marketplace-dev.allizom.org/stats/apps-added-by-payment/?start=2013-10-02&end=2013-11-01&region=worldwide

expected behavior:
Metrics is accessible by all logged-in users

observed behavior:
'Authentication failure detected. Please sign in and try again.' is shown


GET https://marketplace-dev.allizom.org/api/v1/stats/global/apps_added_by_premium/ [HTTP/1.1 403 FORBIDDEN 61ms]

Looks like TypeError: n[0] is undefined include.js:2

Comment 1

[krupa raj[:krupa]]

This js error happens on all accounts including admin accounts

Comment 2

[Davor Spasovski [:spasovski]]

This fixes the JS error: https://github.com/mozilla/marketplace-stats/commit/d028026

Global public stats being visible to all logged in users is coming soon.

Comment 3

[Rob Hudson [:robhudson]]

(In reply to Davor Spasovski [:spasovski] from comment #2)
> Global public stats being visible to all logged in users is coming soon.

That's not what was in the spec. Let's save changing permissions for bug 858294. For now it should just be admins only.

Comment 4

[Davor Spasovski [:spasovski]]

I am fine with that. Thought the global stats would be available to the masses right away.

Comment 5

[Victor Carciu]

Verified as fixed using an admin account

Comment 6

[Wil Clouser [:clouserw]]

comment 3 is correct. this is a stats viewers group - not anyone with an account. thanks