Remove the rest of the old number conversion functions

RESOLVED FIXED in mozilla28

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 826094 [details] [diff] [review]
remove-number

We had JS_ValueToInt32, which is incompatible with ECMA. Luckily it wasn't used in anything, but some testing functions. I wasn't sure what to do about ConvertArguments, should we throw for "j"?
Attachment #826094 - Flags: review?(terrence)
Comment on attachment 826094 [details] [diff] [review]
remove-number

Review of attachment 826094 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me

Be sure to update the wiki. (Although I seem to recall that this method may already be undocumented.)

::: js/src/jsapi.h
@@ +1110,3 @@
>  
>  namespace js {
> +/* DO NOT CALL THIS.  Use JS::ToUint16. */

One space between sentences.

::: js/xpconnect/src/XPCShellImpl.cpp
@@ +395,5 @@
>              return false;
>      }
>  
>      nsCOMPtr<nsIXPConnect> xpc = do_GetService(nsIXPConnect::GetCID());
> +    if(xpc)

Space between if and (.
Attachment #826094 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/65815cafbece
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.