934075 - Add a background to empty menu panels.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1 (WIP)

Maybe? See patch. ;)

Comment 1

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: empty_panels.zip

Menu Panel

• Version 1: Menu status

• Version 2: Hint

• Version 3: Whimsy easter-egg

• Version 4: Mission statement easter-egg

Download Panel

• Version 1: Download status

• Version 2: Hints


I like the idea of using the empty real estate to educate our users, but the whimsy option is temping.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

This patch moves the whimsycorn from corner to corner of the panel when it is empty (only when the panel is a descendent of the popup, not in customization mode).

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8390962 [details] [diff] [review]
Patch

Review of attachment 8390962 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Seems like we should have a separate bug on file for the downloads panel (not whimsy).

::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +48,5 @@
> +  }
> +}
> +
> +@keyframes moveX {
> +  /* These values are adjusted so for the padding on the panel. */ 

Nit: Not entirely English. Also, trailing whitespace. Ditto for other comment.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/bfe98063dfd0

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Pushed a follow-up to fix the path and remove the preprocessor flag in the OSX jar.mn file:
https://hg.mozilla.org/integration/fx-team/rev/f50f63b769ad

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for Aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature for Australis
User impact if declined: blank menu panel shown if users remove all buttons
Testing completed (on m-c, etc.): locally, pushed to fx-team
Risk to taking this patch (and alternatives if risky): none expected
String or IDL/UUID changes made by this patch: none

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/138eb4ef186f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bfe98063dfd0
https://hg.mozilla.org/mozilla-central/rev/f50f63b769ad