934088 - Shortcut for "Bookmark all tabs" (Ctrl+Shift+D) now opens Developer Tools instead (on Windows only)

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Bob49]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131025151332

Steps to reproduce:

User to the problem: http://forums.mozfr.org/viewtopic.php?f=5&t=115786

Before 25 Firefox, Ctrl + Shift + D planned to mark all tabs
Since Firefox 25... shortcuts mark all tabs ... nonfunctional
Since Firefox 25 ... mark all tabs shortcuts (Ctrl + Shift + D) .... used development tools ! See screenshots :

http://www.webm6.com/images/bug1.jpg
http://www.webm6.com/images/bug2.jpg



Expected results:

offer you another shortcut to mark all tabs ?

Comment 1

[patclash]

This affect too Firefox 26.0b1 (Beta and Firefox 27.0a2(Aurora)

Comment 2

[Bob49]

Same for Firefox 28

Comment 3

[Francesco Lodolo [:flod]]

I think you're referring to "Bookmark all tabs".

On Mac I still have the command with the shortcut (Fx 28), on Linux I don't even have the command.

This should be the menu (with a shortcut set)
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-menubar.inc#409

Here I see "#ifndef MOZ_WIDGET_GTK", which could explain why I'm not seeing the menu at all on Linux
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#356

Comment 4

[Mats Palmgren (inactive)]

Cmd+Shift+D on OSX opens the "Bookmark all tabs" dialog, as expected.
Ctrl+Shift+D on Linux does not appear to do anything (there's no "Bookmark all tabs..."
item in the "Bookmarks" menu either).  Same results in both Firefox 25 and Nightly.

It may just be a mistake (or intentional) on Windows...
-> Dev Tools for further triage.

Comment 5

[Elbart]

I think it's a problem with the localized versions.
See: http://forums.mozillazine.org/viewtopic.php?f=9&t=2767373

In the Hungarian locale, Ctr+Shift+T now toggles the tools instead of opening a previously closed tab.
In the German locale the shortcut assigned to the Inspector in 25 isn't working, because it's still got the old shortcut assigned to it, which is now being used to toggle the tools (Ctrl+Shift+I), see: http://i.imgur.com/jt8QQ6n.png

Comment 6

[Rob Campbell [:rc] (:robcee)]

well this is terrible.

CC'ing flod for help.

Comment 7

[Francesco Lodolo [:flod]]

I was already CCed since I saw the bug in Pascal's bugmail (comment 3) ;-)

I see two different strings with "Bookmark all tabs…", both in browser.dtd

<!ENTITY bookmarkAllTabs.label "Bookmark All Tabs…">
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#98
This one doesn't seem to have a shortcut associated.

<!ENTITY addCurPagesCmd.label "Bookmark All Tabs…">
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-menubar.inc#410

This one uses a shortcut "bookmarkAllTabsKb", which leads to
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#357

So it should depend on bookmarkThisPageCmd.commandkey (set to "d" in en-US)
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#123

And it's set to "d" in French too in all branches
http://transvision.mozfr.org/?repo=release&sourcelocale=en-US&locale=fr&search_type=entities&recherche=bookmarkThisPageCmd.commandkey

I'll have to try with Windows to check what happens there, but I don't think it's a l10n issue.

Comment 8

[Francesco Lodolo [:flod]]

On Windows I don't have a menu but CTRL+SHIFT+D is actually bookmarks all tabs :-\

Menu for Developer tools:

devToolboxMenuItem.label = Toggle Tools
devToolboxMenuItem.keycode = I

In French is set to "D", so it's a localization problem
http://transvision.mozfr.org/?repo=central&sourcelocale=en-US&locale=fr&search_type=entities&recherche=devToolboxMenuItem.keycode

Théo, can you take a look and eventually move it to the French component?

Comment 9

[Elbart]

Fr:
http://transvision.mozfr.org/?repo=release&sourcelocale=en-US&locale=fr&search_type=entities&recherche=devToolboxMenuItem.key
http://transvision.mozfr.org/?repo=release&sourcelocale=en-US&locale=fr&search_type=entities&recherche=bookmarkThisPageCmd.c

Both set to D in fr but not in en-US

De:
http://transvision.mozfr.org/?repo=release&sourcelocale=en-US&locale=de&search_type=entities&recherche=devToolboxMenuItem.key
http://transvision.mozfr.org/?repo=release&sourcelocale=en-US&locale=de&search_type=entities&recherche=inspector.commandkey

Both set to I in de but not in en-US

Hu:
http://transvision.mozfr.org/?repo=release&sourcelocale=en-US&locale=hu&search_type=strings_entities&recherche=devToolboxMenuItem.key
http://transvision.mozfr.org/?repo=release&sourcelocale=en-US&locale=hu&search_type=entities&whole_word=whole_word&recherche=tabCmd.accesskey
Here the keys seem to be flipped for hu.

Comment 10

[Théo Chevalier]

(In reply to Francesco Lodolo [:flod] from comment #8)
> On Windows I don't have a menu but CTRL+SHIFT+D is actually bookmarks all
> tabs :-\
> 
> Menu for Developer tools:
> 
> devToolboxMenuItem.label = Toggle Tools
> devToolboxMenuItem.keycode = I
> 
> In French is set to "D", so it's a localization problem
> http://transvision.mozfr.org/?repo=central&sourcelocale=en-
> US&locale=fr&search_type=entities&recherche=devToolboxMenuItem.keycode
> 
> Théo, can you take a look and eventually move it to the French component?

OK, will fix that for French for Firefox 25.

I think I will go for CTRL+Shift+B for devToolboxMenuItem.keycode , there is not much free keys :\

Comment 11

[Théo Chevalier]

err, 26 :)

Comment 12

[Francesco Lodolo [:flod]]

Personally I usually don't change keyboard shorcuts, only access keys.

Comment 13

[patclash]

(In reply to Théo Chevalier [:tchevalier] from comment #10)
> (In reply to Francesco Lodolo [:flod] from comment #8)
> > On Windows I don't have a menu but CTRL+SHIFT+D is actually bookmarks all
> > tabs :-\
> > 
> > Menu for Developer tools:
> > 
> > devToolboxMenuItem.label = Toggle Tools
> > devToolboxMenuItem.keycode = I
> > 
> > In French is set to "D", so it's a localization problem
> > http://transvision.mozfr.org/?repo=central&sourcelocale=en-
> > US&locale=fr&search_type=entities&recherche=devToolboxMenuItem.keycode
> > 
> > Théo, can you take a look and eventually move it to the French component?
> 
> OK, will fix that for French for Firefox 25.
> 
> I think I will go for CTRL+Shift+B for devToolboxMenuItem.keycode , there is
> not much free keys :\

Warning ! : the keyboard shortcut "Ctrl+Shift+B" open all bookmarks !!! for everyone ....

Comment 14

[Théo Chevalier]

(In reply to patclash from comment #13)
> (In reply to Théo Chevalier [:tchevalier] from comment #10)
> > (In reply to Francesco Lodolo [:flod] from comment #8)
> > > On Windows I don't have a menu but CTRL+SHIFT+D is actually bookmarks all
> > > tabs :-\
> > > 
> > > Menu for Developer tools:
> > > 
> > > devToolboxMenuItem.label = Toggle Tools
> > > devToolboxMenuItem.keycode = I
> > > 
> > > In French is set to "D", so it's a localization problem
> > > http://transvision.mozfr.org/?repo=central&sourcelocale=en-
> > > US&locale=fr&search_type=entities&recherche=devToolboxMenuItem.keycode
> > > 
> > > Théo, can you take a look and eventually move it to the French component?
> > 
> > OK, will fix that for French for Firefox 25.
> > 
> > I think I will go for CTRL+Shift+B for devToolboxMenuItem.keycode , there is
> > not much free keys :\
> 
> Warning ! : the keyboard shortcut "Ctrl+Shift+B" open all bookmarks !!! for
> everyone ....

AFAICT, not on Linux, but I will use a Windows build to find a free key. Thanks for the warning

(In reply to Francesco Lodolo [:flod] from comment #12)
> Personally I usually don't change keyboard shorcuts, only access keys.

I usually do that too, but at some point, keys have been changed (I is for Inspector), and I can't just restore all the original keys

Comment 15

[Benoit]

I think we should go back to using the english keycodes: Ctrl+Shift+I for Developer Tools, Ctrl+Shift+C for Inspector.

Otherwise we'll keep bumping into this problem everytime a shortcut is added.

Comment 16

[Théo Chevalier]

(In reply to Benoit from comment #15)
> I think we should go back to using the english keycodes: Ctrl+Shift+I for
> Developer Tools, Ctrl+Shift+C for Inspector.
> 
> Otherwise we'll keep bumping into this problem everytime a shortcut is added.

I'm afraid that's the best solution. Thanks Benoit

Comment 17

[Théo Chevalier]

Bug 891556 actually changed the shortcut from I to C for Inspector in en-US without updating the entity name (see Archaopteryx post on dev.l10n)

Pushed from central to beta, so that Firefox 25 will be the only affected version.

http://hg.mozilla.org/l10n-central/fr/rev/c7a569414f48
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/c7a569414f48
http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/c7a569414f48