934171 - test_ocsp_stapling.js fails with NSS 3.15.3 because GetHostForSNI in TLSServer.h wrongly assumes null-termination of SNI hostname

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: fix-GetHostForSNI.patch

> // TODO: is aSrvNameArr[i].data guaranteed to be null-terminated?

Nope.

Comment 1

[Patrick McManus [:mcmanus]]

Comment on attachment 826359 [details] [diff] [review]
fix-GetHostForSNI.patch

Review of attachment 826359 [details] [diff] [review]:
-----------------------------------------------------------------

bsmith asked on irc if I could take a look at this.. lgtm

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6207648827f1

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6207648827f1

Comment 4

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 826359 [details] [diff] [review]
fix-GetHostForSNI.patch

Ok - note to self: don't ship code with TODO comments in it.

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ca2aaf705a4d

I checked this in without approval because it is a trivial test-only fix for bustage that I caused when uplifting bug 898431 to mozilla-aurora.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/84ba97b0b8e0