934205 - Add link to install more themes from the Add-on Manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Matthew N. [:MattN]]

I've had multiple people ask me how to install new themes in Firefox because they couldn't figure it out on their own.

There is a section on the Get Add-ons tab for Featured Themes but there are some issues with that:
1) For some people this section is below-the-fold depending on their resolution and the current layout of the content on the server.
2) Some people don't think of themes as add-ons and don't even look at the get add-ons section.

There is also the search box in the add-on manager which can search AMO but it doesn't include new themes since AMO uses two separate search indices for extensions and themes. There isn't an API to search both and that's unlikely to be fixed anytime soon as there were technical reasons which caused them not to be combined when getpersonas.com merged into AMO.

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 Add info-bar with a link to AMO theme homepage

I propose that we add an info-bar like the plugin-check one which links to the AMO theme homepage (https://addons.mozilla.org/firefox/themes/ ). That page includes both lightweight and full themes for installation. It's not necessarily the ideal solution but based on the various solutions I considered, it seemed like the right one, at least as an incremental improvement.

Comment 2

[Matthew N. [:MattN]]

Attachment: Screenshot of v.1

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 826399 [details] [diff] [review]
v.1 Add info-bar with a link to AMO theme homepage

Review of attachment 826399 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/content/extensions.js
@@ +716,5 @@
>        }
>      },
>  
> +    cmd_getThemes: {
> +      isEnabled: () => true,

Not all applications will define the extensions.getAddons.themes.browseURL preference, and it does need to stay per-application. So if the pref doesn't have a value, you'll need to ensure this command is disabled, and the infobar is hidden.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 934205 - Add link to install more themes from the Add-on Manager. Original patch written by MattN.

Review commit: https://reviewboard.mozilla.org/r/99340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99340/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8819615 [details]
Bug 934205 - Add link to install more themes from the Add-on Manager. Original patch written by MattN.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99340/diff/1-2/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: appearance.png

The updated patch uses similar language from the Customize mode when the palette is empty. There we use the wording, "Want more tools? _Choose from thousands of add-ons_" (where the _ signifies a link).

This patch uses "Looking to personalize your browser? _Choose from thousands of themes._"

Verdi, can you approve this?

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8819615 [details]
Bug 934205 - Add link to install more themes from the Add-on Manager. Original patch written by MattN.

https://reviewboard.mozilla.org/r/99340/#review100050

Thanks for finishing this up!

Comment 8

[Verdi [:verdi] Best to slack me]

Comment on attachment 8820115 [details]
appearance.png

Let's make this consistent with the disco pane - a blue button with the string, "See more themes" below the list of installed themes.

Comment 9

[Verdi [:verdi] Best to slack me]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Created attachment 8820115 [details]
> appearance.png
> 
> The updated patch uses similar language from the Customize mode when the
> palette is empty. There we use the wording, "Want more tools? _Choose from
> thousands of add-ons_" (where the _ signifies a link).
> 
> This patch uses "Looking to personalize your browser? _Choose from thousands
> of themes._"
> 
> Verdi, can you approve this?

After more consideration, let's go with the design as submitted.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/387e7c8bcc51
Add link to install more themes from the Add-on Manager. Original patch written by MattN. r=MattN

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8820115 [details]
appearance.png

Thanks! Adjusting the flag based on previous comment from :verdi.

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/387e7c8bcc51

Comment 13

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 53.0a2 (2017-03-06) Win 10, Ubuntu 14.04, OS X 10.11.