Closed
Bug 934206
Opened 12 years ago
Closed 12 years ago
Disable browser_248970_b_perwindowpb.js for leaking
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: ttaubert, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
993 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
I spent lots of time yesterday trying to figure out why browser_248970_b_perwindowpb.js is leaking and I alas haven't been successful. I suggest disabling this test for now (to unblock bug 932898) as it's covering quite basic stuff that should be taken care of by other tests as well.
The test should also be rewritten, it sets, collects, and compares form data in an outdated manner and we should be able to simplify it a lot. I will file a follow-up bug to address this.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #826398 -
Flags: review?(ehsan)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 826398 [details] [diff] [review]
0004-Bug-934206-Disable-browser_248970_b_perwindowpb.js-f.patch
Review of attachment 826398 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the follow-up bug filed to re-enable this test. :-) Please mention the bug# in the comment inside the manifest.
Attachment #826398 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•