934262 - Fix -Wtautological-constant-out-of-range-compare warnings in js/src/jit/

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-warnings.patch

I hit the following compiler warnings (as errors) when building a 32-bit optimized debug build on OS X:

js/src/jit/AsmJSModule.cpp:863:37 [-Wsign-compare] comparison of integers of different signs: 'int' and 'const uint32_t' (aka 'const unsigned int')

js/src/jit/Snapshots.cpp:365:26: warning: comparison of constant 28 with expression of type 'Code' (aka 'XMMRegisterID') is always true [-Wtautological-constant-out-of-range-compare]
    JS_ASSERT(reg.code() < MIN_REG_FIELD_ESC);
              ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~

js/src/jit/Snapshots.cpp:522:26: warning: comparison of constant 28 with expression of type 'Code' (aka 'XMMRegisterID') is always true [-Wtautological-constant-out-of-range-compare]
    JS_ASSERT(reg.code() < MIN_REG_FIELD_ESC);
              ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 826491 [details] [diff] [review]
fix-warnings.patch

Thanks!

Comment 2

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/282e0c10de45

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/282e0c10de45