Closed Bug 934322 Opened 11 years ago Closed 10 years ago

Intermittent talos KeyError: 'CMD'

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox27 wontfix, firefox28 fixed, firefox29 fixed, firefox-esr24 wontfix)

Status:
RESOLVED FIXED
Milestone:
mozilla29
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
firefox-esr24 --- wontfix

People

(Reporter: philor, Assigned: jmaher)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

catch and ignore this specific error (1.0)
1.78 KB, patch
dminor
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=30058232&tree=Mozilla-Inbound
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound talos tp5o on 2013-11-03 17:53:31 PST for push 745c8b54f04f
slave: talos-r4-snow-075

18:10:05     INFO -  __end_tp_report
18:10:05     INFO -  __start_cc_report
18:10:05     INFO -  _x_x_mozilla_cycle_collect,108794
18:10:05     INFO -  __end_cc_report
18:10:05     INFO -  __startTimestamp1383530990207__endTimestamp
18:10:05     INFO -  MOZ_EVENT_TRACE sample 1383530990292 93
18:10:05     INFO -  MOZ_EVENT_TRACE sample 1383530990397 105
18:10:05     INFO -  MOZ_EVENT_TRACE sample 1383530990419 21
18:10:05     INFO -  MOZ_EVENT_TRACE stop 1383530990419
18:10:05    ERROR -  Traceback (most recent call last):
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/bin/talos", line 9, in <module>
18:10:05     INFO -      load_entry_point('talos==0.0', 'console_scripts', 'talos')()
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/run_tests.py", line 339, in main
18:10:05     INFO -      sys.exit(run_tests(parser))
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/run_tests.py", line 279, in run_tests
18:10:05     INFO -      talos_results.add(mytest.runTest(browser_config, test))
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/ttest.py", line 421, in runTest
18:10:05     INFO -      self.cleanupAndCheckForCrashes(browser_config, profile_dir, test_config['name'])
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/ttest.py", line 130, in cleanupAndCheckForCrashes
18:10:05     INFO -      browser_config['browser_wait'])
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/ffprocess.py", line 63, in cleanupProcesses
18:10:05     INFO -      if self.checkAllProcesses(process_name, child_process):
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/ffprocess.py", line 53, in checkAllProcesses
18:10:05     INFO -      return self.ProcessesWithNames(*([process_name, child_process]+self.extra_prog))
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/talos/ffprocess.py", line 32, in ProcessesWithNames
18:10:05     INFO -      pids = mozpid.get_pids(process_name)
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/mozprocess/pid.py", line 81, in get_pids
18:10:05     INFO -      return [pid for pid,_ in running_processes(name)]
18:10:05     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/mozprocess/pid.py", line 57, in running_processes
18:10:05     INFO -      command = process['CMD']
18:10:05     INFO -  KeyError: 'CMD'
18:10:05    ERROR - Return code: 1
Joel, any idea what might be going on here?
Flags: needinfo?(jmaher)
this looks like a bug in mozprocess, I will work on getting it fixed
Flags: needinfo?(jmaher)
(In reply to Joel Maher (:jmaher) from comment #17)
> this looks like a bug in mozprocess, I will work on getting it fixed

Any luck with this? :-)
Flags: needinfo?(jmaher)
I had started looking into this and my initial debugging yielded no success.  The root cause appears to be more of an issue with no process running or not being able to terminate the process.  This is a problem where I would need to spend a couple days hacking on it.
Flags: needinfo?(jmaher)
Assignee: nobody → jmaher
Status: NEW → ASSIGNED

        Attachment #8366778 -
        Flags: review?(dminor)

    
  

        Attachment #8366778 -
        Flags: review?(dminor) → review+

    
    

    
  
https://hg.mozilla.org/build/talos/rev/65cb1be457e7.

I will mark this as resolved when we deploy- although until this is rolled out en masse, we will still need this for starring.

    
    

    
      
  

    
    

    
      
  

    
  
Depends on: 965731

    
  
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          status-firefox27:
          --- → wontfix

          status-firefox28:
          --- → fixed

          status-firefox29:
          --- → fixed

          status-firefox-esr24:
          --- → wontfix
Target Milestone: --- → mozilla29

    
    

    
      
  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: