934327 - Give OCSP-related NSS errors symbolic names in xpcshell tests

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Give OCSP-related NSS errors symbolic names in xpcshell tests

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 826579 [details] [diff] [review]
Give OCSP-related NSS errors symbolic names in xpcshell tests

Review of attachment 826579 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/tests/unit/head_psm.js
@@ +26,5 @@
> +const SEC_ERROR_OCSP_UNAUTHORIZED_REQUEST               = SEC_ERROR_BASE + 124;
> +const SEC_ERROR_OCSP_UNKNOWN_CERT                       = SEC_ERROR_BASE + 126;
> +const SEC_ERROR_OCSP_MALFORMED_RESPONSE                 = SEC_ERROR_BASE + 129;
> +const SEC_ERROR_OCSP_UNAUTHORIZED_RESPONSE              = SEC_ERROR_BASE + 130;
> +const SEC_ERROR_OCSP_OLD_RESPONSE                       = SEC_ERROR_BASE + 132;  

I will fix the whitespace

Comment 2

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 826579 [details] [diff] [review]
Give OCSP-related NSS errors symbolic names in xpcshell tests

Review of attachment 826579 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. r=me with either the change to Ci.nsINSSErrorsService.NSS_SEC_ERROR_BASE or a good reason to not do it.

::: security/manager/ssl/tests/unit/head_psm.js
@@ +14,5 @@
>  let { ctypes } = Cu.import("resource://gre/modules/ctypes.jsm");
>  
>  let gIsWindows = ("@mozilla.org/windows-registry-key;1" in Cc);
>  
> +const SEC_ERROR_BASE = -0x2000;

I think it makes sense to use Ci.nsINSSErrorsService.NSS_SEC_ERROR_BASE here.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2306c8fdea11

Comment 4

[Dana Keeler (she/her) [:keeler]]

https://hg.mozilla.org/releases/mozilla-beta/rev/68e81eb0148e
(landed with bug 887321, bug 929617, bug 943115, bug 938805, bug 932519, and bug 930209)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/6135344dada1