934337 - Get rid of custom rules fiddling with SHARED_LIBRARY

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Get rid of custom rules fiddling with SHARED_LIBRARY

While here, remove other custom rules in the same Makefiles.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Get rid of custom rules fiddling with SHARED_LIBRARY

NO_DIST_INSTALL was preventing SHARED_LIBRARY_DEST from doing anything.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 826621 [details] [diff] [review]
Get rid of custom rules fiddling with SHARED_LIBRARY

I still have test failures with this :(

Comment 4

[Mike Hommey [:glandium]]

Attachment: Get rid of custom rules fiddling with SHARED_LIBRARY

I think I got it right this time. The problem was that components are not installed with the SHARED_LIBRARY INSTALL_TARGETS.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 826696 [details] [diff] [review]
Get rid of custom rules fiddling with SHARED_LIBRARY

These look good!

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f71c4ec9ed

Note I had to preserve the rules.mk include in xpcom/tests/component_no_aslr/Makefile.in because of LDFLAGS.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e3f71c4ec9ed