934338 - Few cleanups in layout/style/test/Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Few cleanups in layout/style/test/Makefile.in

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 826592 [details] [diff] [review]
Few cleanups in layout/style/test/Makefile.in

># HG changeset patch
># User Mike Hommey <[e-mail]>
># Date 1383539501 -32400
>#      Mon Nov 04 13:31:41 2013 +0900
># Node ID fe14f35a68b67c6d83c984797860231221243ad8
># Parent  91943bbc8286b1a9caeaae61c9271eb9d215d10c
>Bug 934338 - Few cleanups in layout/style/test/Makefile.in
>
>diff --git a/layout/style/test/Makefile.in b/layout/style/test/Makefile.in
>--- a/layout/style/test/Makefile.in
>+++ b/layout/style/test/Makefile.in
>@@ -131,17 +131,16 @@ MOCHITEST_FILES =	test_acid3_test46.html
> 		test_parse_ident.html \
> 		test_parse_rule.html \
> 		test_parse_url.html \
> 		test_parser_diagnostics_unprintables.html \
> 		test_pixel_lengths.html \
> 		test_pointer-events.html \
> 		file_position_sticky.html \
> 		test_position_sticky.html \
>-		test_property_database.html \
> 		test_priority_preservation.html \
> 		test_property_syntax_errors.html \
> 		test_redundant_font_download.html \
> 		redundant_font_download.sjs \
> 		test_rem_unit.html \
> 		test_rule_insertion.html \
> 		test_rule_serialization.html \
> 		test_rules_out_of_sheets.html \
>@@ -175,17 +174,16 @@ MOCHITEST_FILES =	test_acid3_test46.html
> 		test_value_storage.html \
> 		test_viewport_units.html \
> 		test_visited_image_loading.html \
> 		test_visited_image_loading_empty.html \
> 		test_visited_lying.html \
> 		test_visited_pref.html \
> 		test_visited_reftests.html \
> 		animation_utils.js \
>-		css_properties.js \
> 		property_database.js \
> 		descriptor_database.js \
> 		unstyled.xml \
> 		unstyled.css \
> 		unstyled-frame.xml \
> 		unstyled-frame.css \
> 		redirect.sjs \
> 		post-redirect-1.css \
>@@ -220,22 +218,26 @@ MOCHITEST_FILES =	test_acid3_test46.html
> _VISITED_REFTEST_FILES = \
> 		$(shell find $(topsrcdir)/layout/reftests/css-visited/ -name '*.html' -o -name '*.xhtml') \
> 		$(topsrcdir)/layout/reftests/svg/pseudo-classes-02.svg \
> 		$(topsrcdir)/layout/reftests/svg/pseudo-classes-02-ref.svg \
> 		$(topsrcdir)/layout/reftests/svg/as-image/lime100x100.svg \
> 		$(topsrcdir)/layout/reftests/svg/as-image/svg-image-visited-1-helper.svg \
> 		$(topsrcdir)/layout/reftests/svg/as-image/svg-image-visited-2-helper.svg \
> 		$(NULL)
>-
>-include $(topsrcdir)/config/rules.mk
>+_VISITED_REFTEST_DEST = $(DEPTH)/_tests/testing/mochitest/tests/$(relativesrcdir)/css-visited/
>+INSTALL_TARGETS += _VISITED_REFTEST

Can we use VISITED_REFTEST* here instead of _VISITED_REFTEST*? The leading underscore makes me think it is a local/reserved variable.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef68e2419a37

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ef68e2419a37