934440 - Statically assert that MEDIA_STREAM_DEST_TRACK_ID is different than AUDIO_NODE_STREAM_TRACK_ID

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Josh Matthews [:jdm]]

There's a comment in MediaStreamAudioDestinationNode stating that the two constants should be different. We should add a static assertion that checks that this is true using static_assert.

Comment 1

[Peiyong Lin[:lpy](UTC+8)]

Seems easy and I can learn something from the code, I will try to work on it after I read some code.
http://mxr.mozilla.org/mozilla-central/source/content/media/webaudio/MediaStreamAudioDestinationNode.cpp#26
Comment is in lien 26 in MediaStreamAudioDestinationNode

Comment 2

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug934440.patch

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 827101 [details] [diff] [review]
bug934440.patch

Review of attachment 827101 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/MediaStreamAudioDestinationNode.cpp
@@ +22,5 @@
>  
>  NS_IMPL_ADDREF_INHERITED(MediaStreamAudioDestinationNode, AudioNode)
>  NS_IMPL_RELEASE_INHERITED(MediaStreamAudioDestinationNode, AudioNode)
>  
> +// This must be a different value than AUDIO_TRACK

This comment can go away now; the assertion make it clear.

Comment 4

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug934440.patch

delete comment

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0595650a11bd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/integration/b2g-inbound/rev/fca4c04c4afa

https://tbpl.mozilla.org/php/getParsedLog.php?id=30416664&tree=B2g-Inbound

Please make sure this compiles locally before requesting checkin.

Comment 7

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug934440.patch

Comment 8

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug934440.patch

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d1da506d529f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1da506d529f