93450 - memory/resource leak of global CERT locks

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Jeff Hostetler]

nss/lib/certdb/{certdb.c,pcertdb.c} leak the static global
locks "certTrustLock", "certRefCountLock", and "dbLock".

consider adding the following to certdb.c:

void CERT_DeleteGlobalLocks(void)
{
    if (certTrustLock)
    {
	PZ_DestroyLock(certTrustLock);
	certTrustLock = NULL;
    }
    
    if (certRefCountLock)
    {
	PZ_DestroyLock(certRefCountLock);
	certRefCountLock = NULL;
    }
}

and the following to pcertdb.c:

void CERT_Shutdown(CERTCertDBHandle * handle)
{
    if (dbLock)
    {
	PZ_DestroyLock(dbLock);
	dbLock = NULL;
    }
}

and adding calls to them to nss/lib/nss/nssinit.c::NSS_Shutdown()

Comment 1

[Wan-Teh Chang]

Assigned the bug to Bob.

Comment 2

[Keyser Sose]

Makring NEW> thanks for the patch jeff

Comment 3

[Wan-Teh Chang]

Changed the QA contact to Bishakha.

Comment 4

[Robert Relyea]

This code is checked into 3.4, though the relavent code has moved to the
softoken (which is the only place the databases are ever referenced.