934503 - Activated hidden plugins (Flash) show the blue plugin icon

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benjamin Smedberg]

The blue plugin notification icon is only supposed to be shown when the plugin is not active. In today's nightly http://benjamin.smedbergs.us/tests/ctptests/flash-hidden.html shows the blue icon. This is a regression from bug 745187. I think I already have it fixed in another prototype in my tree, but I'm going to try and split it out to get it fixed now.

Comment 1

[Benjamin Smedberg]

Attachment: Activated hidden plugins should not show the hidden plugin notification icon

Comment 2

[Benjamin Smedberg]

Attachment: Test for bug 934503

Comment 3

[Benjamin Smedberg]

https://hg.mozilla.org/integration/fx-team/rev/a8131d677d9b
https://hg.mozilla.org/integration/fx-team/rev/f631148645b3

This will be uplifted with the patch that regressed it.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/b0bce439c6e2 for a failing browser-chrome test: https://tbpl.mozilla.org/php/getParsedLog.php?id=30103597&tree=Fx-Team

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33fdb96c1ead

Comment 6

[Benjamin Smedberg]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8da8761dab7d
https://hg.mozilla.org/releases/mozilla-beta/rev/2cdb3f4cd18f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/2cdb3f4cd18f

Comment 8

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:
FF 26 beta 3
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build Id:20131107161719
OS: Win 7 x64

Comment 9

[Paul Silaghi, QA [:pauly]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #0)
> The blue plugin notification icon is only supposed to be shown when the
> plugin is not active. In today's nightly
> http://benjamin.smedbergs.us/tests/ctptests/flash-hidden.html shows the blue
> icon. 
Still remains blue if Flash is CTP blocked and allowing. But it gets normal after refresh.
What do you think?

Comment 10

[Benjamin Smedberg]

Do you mean that if flash is blocked, and then you allow it via the doorhanger, the icon remains blue? I think that's the expected behavior.

Comment 11

[Paul Silaghi, QA [:pauly]]

But that means the plugin is active, so it's contrary to:
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #0)
> The blue plugin notification icon is only supposed to be shown when the
> plugin is not active.

Comment 12

[Benjamin Smedberg]

Once we've shown the icon, we don't want to change it until the next page load. It would be weird flickering.

Comment 13

[Paul Silaghi, QA [:pauly]]

Thanks for explaining.
Verified fixed 28.0a1 (2013-11-10) Win 7

Comment 14

[Bogdan Maris, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0

Verified as fixed on latest Aurora 27.0a2 (buildID: 20131121004004).