934514 - Fennec crashes on KitKat

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

On I believe beta and up, we're crashing at startup on Android 4.4 KitKat. I get the following in logcat:

W/System.err( 5546): java.lang.NoSuchFieldError: no field with name='mNativeSurface' signature='I' in class Landroid/view/Surface;
W/System.err( 5546): 	at org.mozilla.gecko.GeckoAppShell.nativeInit(Native Method)
W/System.err( 5546): 	at org.mozilla.gecko.GeckoAppShell.nativeInit(Native Method)
W/System.err( 5546): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:315)
W/System.err( 5546): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:176)

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

We had a heads up about this problem from Google and implemented a fix, but some other changes busted that. Patch coming.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Actually I think that message is a red herring, the exception should be getting handled fine. And we crash at 0x0, not 0xdeaddood, so I don't think it's a JVM abort. Digging.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Ah, I thought the MOZ_CRASH() wouldn't do anything on a release build, but that's apparently not the case. Boo.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't access for non-existant field on Android 4.4

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

AndroidBridge::GetFieldID() (which is what getField calls) aborts on failure, so we never made it to the code that I had added for KLP (now KitKat). The patch just avoids a lookup that is known to fail.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 826820 [details] [diff] [review]
Don't access for non-existant field on Android 4.4

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Android 4.4 release
User impact if declined: Crash on startup
Testing completed (on m-c, etc.): local only so far
Risk to taking this patch (and alternatives if risky): low risk
String or IDL/UUID changes made by this patch: none

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 826820 [details] [diff] [review]
Don't access for non-existant field on Android 4.4

Just adding my r+ for expedience - this is pretty benign and we need to fix this asap I think.

Comment 8

[Chris Lord [:cwiiis]]

Verified the fix works on a Nexus 5 running out-of-the-box images.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Let's get this on central & confirm builds are green so we can uplift to branches - will hold the Fennec 26 beta 2 go to build for this.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/mozilla-central/rev/fadc8a168bbc

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Looking good on central https://tbpl.mozilla.org/?rev=fadc8a168bbc

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/60c78f0a3474
https://hg.mozilla.org/releases/mozilla-beta/rev/b0025760b098

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b0025760b098

Comment 17

[Tony Chung [:tchung]]

Verified fix on 26 beta 2.   beta starts up correctly on Android 4.4, Nexus 5 device.