Closed Bug 934557 Opened 6 years ago Closed 6 years ago

Handlify JS::ToBoolean, remove JS_ValueToBoolean

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [qa-])

Attachments

(1 file)

Attached patch to-booleanSplinter Review
No description provided.
Attachment #826870 - Flags: review?(terrence)
Summary: Handlify JS_ValueToBoolean → Handlify JS::ToBoolean, remove JS_ValueToBoolean
Comment on attachment 826870 [details] [diff] [review]
to-boolean

Review of attachment 826870 [details] [diff] [review]:
-----------------------------------------------------------------

Woot! Very nice! r=me

::: js/src/jit/MIR.h
@@ +969,5 @@
>      const js::Value *vp() const {
>          return &value_;
>      }
> +    const bool valueToBoolean() const {
> +        // Hack to avoid this everywhere else in the JIT.

That's a bit of a sentence fragment. How about:
// A hack to avoid this wordy pattern everywhere in the JIT.
Attachment #826870 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/2f9458266db7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.