934557 - Handlify JS::ToBoolean, remove JS_ValueToBoolean

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S. (please needinfo tschuster)]

Attachment: to-boolean

Comment 1

[Terrence Cole [:terrence]]

Comment on attachment 826870 [details] [diff] [review]
to-boolean

Review of attachment 826870 [details] [diff] [review]:
-----------------------------------------------------------------

Woot! Very nice! r=me

::: js/src/jit/MIR.h
@@ +969,5 @@
>      const js::Value *vp() const {
>          return &value_;
>      }
> +    const bool valueToBoolean() const {
> +        // Hack to avoid this everywhere else in the JIT.

That's a bit of a sentence fragment. How about:
// A hack to avoid this wordy pattern everywhere in the JIT.

Comment 2

[Tom S. (please needinfo tschuster)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2f9458266db7

Comment 3

[Tom S. (please needinfo tschuster)]

Updated reference and SpiderMonkey 31, added https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS::ToBoolean.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f9458266db7