Closed
Bug 934557
Opened 11 years ago
Closed 11 years ago
Handlify JS::ToBoolean, remove JS_ValueToBoolean
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [qa-])
Attachments
(1 file)
21.57 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #826870 -
Flags: review?(terrence)
Updated•11 years ago
|
Summary: Handlify JS_ValueToBoolean → Handlify JS::ToBoolean, remove JS_ValueToBoolean
Comment 1•11 years ago
|
||
Comment on attachment 826870 [details] [diff] [review] to-boolean Review of attachment 826870 [details] [diff] [review]: ----------------------------------------------------------------- Woot! Very nice! r=me ::: js/src/jit/MIR.h @@ +969,5 @@ > const js::Value *vp() const { > return &value_; > } > + const bool valueToBoolean() const { > + // Hack to avoid this everywhere else in the JIT. That's a bit of a sentence fragment. How about: // A hack to avoid this wordy pattern everywhere in the JIT.
Attachment #826870 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 2•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/2f9458266db7
Keywords: dev-doc-needed
Assignee | ||
Comment 3•11 years ago
|
||
Updated reference and SpiderMonkey 31, added https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS::ToBoolean.
Keywords: dev-doc-needed → dev-doc-complete
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2f9458266db7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•