934727 - Use xhr.addEventListener in l10n.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

This is an offspring of bug 914414. We want to use xhr eventListeners but that requires changes to bto, so we'll deal with it as a followup to that bug here.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch, l10n part

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch, gaia part

Comment 3

[Staś Małolepszy :stas]

Comment on attachment 8404195 [details] [diff] [review]
patch, l10n part

Review of attachment 8404195 [details] [diff] [review]:
-----------------------------------------------------------------

So much nicer. r=me.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8405205 [details] [review]
pull request

For this type of changes, that does not really change any behaviors or API, please consider that you don't need me as long you're careful with memory/perf.

Comment 6

[Staś Małolepszy :stas]

Thank, Vivien, this will help streamline the process.

Gandalf, it looks like the tests don't pass with this pull request:

https://travis-ci.org/mozilla-b2g/gaia/jobs/22751188#L2549

It might have something to do with Sinon's FakeXHR:

https://github.com/mozilla-b2g/gaia/blob/5c56b25486e2b9ac438ef9c3a7825ed4445d5b34/apps/gallery/test/unit/l10n/l10n_test.js#L54

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Staś Małolepszy :stas from comment #6)
> It might have something to do with Sinon's FakeXHR:
> 
> https://github.com/mozilla-b2g/gaia/blob/
> 5c56b25486e2b9ac438ef9c3a7825ed4445d5b34/apps/gallery/test/unit/l10n/
> l10n_test.js#L54

Good catch. Upgrading sinon to 1.9.1 fixed tests. Filed bug 995425.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

ok, travis is happy with the updated sinon. Let's land this.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Bug 995425 bounced, so I assume this shouldn't land yet.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/b6d1c7fae27ec22ee06e3da7898fe2565fc0a8c0

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/l20n/l20n.js/commit/ddad3f2398606be7c7bd12d726de8440daf7bf51