934779 - Fix a few more widget/windows warnings

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Daniel Holbert [:dholbert]]

Fixing a few more windows widget build warnings:
{
widget/windows/TaskbarWindowPreview.cpp(157) : warning C4018: '<=' : signed/unsigned mismatch
widget/windows/nsClipboard.cpp(732) : warning C4018: '>' : signed/unsigned mismatch
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: 934779-fix.patch

Comment 2

[Daniel Holbert [:dholbert]]

For the first hunk: note that nsTaskbarProgressState is typedeffed to 'long', which is why we warn about it being compared to the (unsigned) result of ArraySize().

For the second hunk: outDataLen is a uint32_t*, and endOfData is an int32_t but is known-nonnegative when we get to the comparison, due to the checks on it above in the patch's contextual code (for endOfData < -1, and endOfData == -1).

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd1a07426d4c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd1a07426d4c