Closed Bug 934805 Opened 6 years ago Closed 6 years ago

Ensure client code passes in sane additionalParts argument to baseDomain functions

Categories

(Core :: Networking: Domain Lists, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch enforce_additionalParts (obsolete) — Splinter Review
Passing negative values to nsIEffectiveTLDService:GetBaseDomain{FromHost} is {WRONG,EVIL,Generally a bug} and should fail early (so we don't hit issues like bug 822869 comment 64).

Try run (with patches from 822869, too):

  https://tbpl.mozilla.org/?tree=Try&rev=084b7ed434d6
Attachment #827153 - Flags: review?(hurley)
https://tbpl.mozilla.org/?tree=Try&rev=14398251a9c4
Assignee: nobody → jduell.mcbugs
Attachment #827153 - Attachment is obsolete: true
Attachment #827153 - Flags: review?(hurley)
Attachment #827164 - Flags: review?(hurley)
Comment on attachment 827164 [details] [diff] [review]
v2: now even less broken!

Review of attachment 827164 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, the mismatch between signedness of public and internal functions makes me feel less-than-good, but that ship sailed a while ago, and it's not your fault. r=me
Attachment #827164 - Flags: review?(hurley) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/10ccf87af449
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.