934850 - [MMS] Received messages are all empty, no attachment or text content.

Status: RESOLVED DUPLICATE of bug 930882

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Enpei]

Attachment: time stamp: 12:32, 11/5

Found on master build. After receiving MMS and open it, it's all empty. Buri base image (v1.1) and v1.2 pvt build have no such problem.

Buri
Gaia:     1aee772a384f1ed1148f08c6c7df45d2fe35506e
Gecko:    http://hg.mozilla.org/mozilla-central/rev/b4143e04bea1
BuildID   20131104044747
Version   28.0a1

Comment 1

[Steve Chung [:steveck]]

Looks like a regression in bug 930882, using 'let' in smil module will cause error and all mms related functionality will be failed. Root cause might be some limitation for Javascript v1.7(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Iterators_and_Generators?redirectlocale=en-US&redirectslug=JavaScript%2FGuide%2FIterators_and_Generators). Here is a note in the page:
"The yield keyword is only available to code blocks in HTML wrapped in a <script type="application/javascript;version=1.7"> block (or higher version). XUL script tags have access to these features without needing this special block." 
I think 'let' keyword is also the same here and the solution did work. Hi Julien, we have at least 2 solution for this issue:
 - Replace 'let' with 'var'
 - Add script type "application/javascript;version=1.7" for loading js file in lazyload
Which on do you prefer? :)

Comment 2

[Steve Chung [:steveck]]

Another thought: maybe we should replace 'let' with 'var' in this patch and create another bug for lazyloader version support feature?

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Agreed with using "var" only in content code (for now).

Closing this as Borja backed out the offending patch :)