934900 - [TABLET] Back/Forward and Bookmark buttons are enabled in editing mode if tap on URL bar before loading page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u421692]

Environment:
Device: Samsung Galaxy Tab (Android 4.0.4)
Build: Firefox 28.0a1 (2013-11-03)

Steps to reproduce:
1. Open Firefox
2. Tap on the URL bar and load a page (e.g. www.fifa.com)
3. While loading the page, tap on the URL bar.

Expected result:
Edit mode is opened, and the page(fifa.com) is loaded in the background.
All the toolbar elements are disabled(menu, back, forward, tabs, refresh, bookmark).

Actual result:
Edit mode is opened, and the page(fifa.com) is loaded in the background.
Back/Forward and Bookmark buttons are enabled in editing mode.

Note: This is not a regression, since is has been integrated with bug 918007.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Ensure back/forward are not re-enabled while in editing mode (r=sriram)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Ensure back/forward are not re-enabled while in editing mode

Comment 3

[Lucas Rocha (:lucasr)]

Found a related issue while fixing this. Filed bug 935473 to track it.

Comment 4

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/120a9e538651

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/120a9e538651

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 827974 [details] [diff] [review]
Ensure back/forward are not re-enabled while in editing mode

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new about:home (bug 862793)
User impact if declined: Back/Forward buttons might get re-enabled if the page finishes loading while in editing mode. Being able to use these buttons while in editing mode cause of sorts of strange behaviours in the toolbar. This is a follow-up from bug 918007 which fixed part of the problem.
Testing completed (on m-c, etc.): Landed in m-c, no issues found.
Risk to taking this patch (and alternatives if risky): Fairly low. We simply ensure these buttons are not enabled while in editing mode.
String or IDL/UUID changes made by this patch: n/a

Comment 7

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 28.0a1 (2013-11-12)
Will change the status after verifying the fix on Aurora and Beta

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/39f2074a7cf5
https://hg.mozilla.org/releases/mozilla-beta/rev/9ba6a44a6dfa

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/9ba6a44a6dfa

Comment 10

[Flaviu Cos]

Verified as fixed on builds: 
- aurora 27.0a2 (11.14.2013).
- beta 26.0b4
Device: Asus Transformer Tab (Android 4.0.3)