Closed Bug 934979 Opened 9 years ago Closed 8 years ago

update to django-rest-framework 2.4.4

Categories

(Input Graveyard :: Code Quality, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
2015q1

People

(Reporter: willkg, Assigned: rrosario)

References

Details

(Whiteboard: u=dev c=codequality p= s=input.2015q1)

We should update to django-rest-framework 2.3.8.

We're currently using 2.3.6. We should update to 2.3.8 which has the fix for requiring booleanfields and also some other things that look helpful.

http://django-rest-framework.org/topics/release-notes.html#23x-series
Pushing this off to 2014q1 because I can't get to it this quarter.
Whiteboard: u=dev c=codequality p= s=input.2013q4 → u=dev c=codequality p= s=input.2014q1
Moving this to 2014q2.
Priority: P2 → P3
Whiteboard: u=dev c=codequality p= s=input.2014q1 → u=dev c=codequality p= s=input.2014q2
Bumping this to 2014q3 when I plan to do a round of updates of things.
Whiteboard: u=dev c=codequality p= s=input.2014q2 → u=dev c=codequality p= s=input.2014q3
Summary: update to django-rest-framework 2.3.8 → update to django-rest-framework 2.3.14
Whiteboard: u=dev c=codequality p= s=input.2014q3 → u=dev c=codequality p= s=input.2014q4
One thing to note, in order to upgrade to django-rest-framework >= 2.4, we have to first upgrade South to 1.0.

Ergo, I'm going to have this block on the South upgrade.
Depends on: 900992
Summary: update to django-rest-framework 2.3.14 → update to django-rest-framework 2.4.4
I moved the south bug to next quarter. Moving this one, too.
Whiteboard: u=dev c=codequality p= s=input.2014q4 → u=dev c=codequality p= s=input.2015q1
DRF 3.0 is out now. It is a big of a larger change than upgrading to 2.4, but I think it is worth the change.
Why do you think it's worth going to 3.0 rather than 2.4?
The way that custom serializers and fields are made has been simplified, and is a lot easier to reason about in my opinion. Additionally, there is future work in 3.1 and 3.2 that was sponsored by a Kickstarter campaign that looks useful, like explicit support for API versioning.

Maybe it doesn't actually make sense to spend the effort to upgrade to 3.0 (it will take more work than upgrading to 2.4), but I think 3.0 is an improvement over 2.4.
I'm going to start by upgrading to the latest 2.4.x as long as it supports django 1.7 since that's our goal here. Then I can file a followup to upgrade to DRF 3.x.
Assignee: nobody → rrosario
Target Milestone: --- → 2015q1
Landed in master in: https://github.com/mozilla/fjord/commit/6fe9630128336d4c435a96324b1fd2bcb57d693a

I'll deploy it later today. When deploying, we need to make sure that everything continues to look normal in regards to posting feedback.
Pushed it out just now. It looks good, but I'll keep an eye on it for a bit.

Going to mark it as FIXED.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.