934988 - Australis menu still consumes clicks outside it

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[u428464]

Since bug 596723 landed, the clicks outside panels aren't consumed anymore. That feels much more natural. The Australis panel menu however still consumes the clicks outside it. It's a bit annoying and it's not consistent with other panels behaviour.

Comment 1

[:Gijs (he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #1)
> Since bug 596723 landed, the clicks outside panels aren't consumed anymore.
> That feels much more natural. The Australis panel menu however still
> consumes the clicks outside it. It's a bit annoying and it's not consistent
> with other panels behaviour.

Can you be more explicit about what the problematic behaviour is and what you want to see instead?

Comment 2

[u428464]

I don't know exactly how to explain it. It's clearly a follow-up from bug 596723. Before it landed, when you had a panel opened and for example clicked on a link on the page, first the panel was dismissed and then you had to click a second time to open the link. Now with bug 596723 resolved, you can directly access to the link by clicking on it. It works with every panel except the Australis menu. I hope it's more clear now.

Comment 3

[:Gijs (he/him)]

That's because we explicitly set it to true in http://hg.mozilla.org/projects/ux/rev/d92bea85aa14 - bug 870897. Paging Mike, Mike and Blair to figure out why.

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #3)
> That's because we explicitly set it to true in
> http://hg.mozilla.org/projects/ux/rev/d92bea85aa14 - bug 870897. Paging
> Mike, Mike and Blair to figure out why.

You're talking about consumeoutsideclicks="true"? That patch didn't change that.

Comment 5

[Mike de Boer [:mikedeboer]]

After some testing, it appears that this is indeed not necessary anymore; the zoom and edit controls still function correctly without `consumeoutsideclicks="true"` on the most recent build(s).

Comment 6

[Mike de Boer [:mikedeboer]]

But Dão's right: http://hg.mozilla.org/projects/ux/rev/f7cb839f3bfc added it.

So this is still one for mconley to answer.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/projects/ux/rev/f7cb839f3bfc simply predates bug 596723, so consumeoutsideclicks="true" was necessary just like for all other arrow panels.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

Comment 9

[Mike Conley (:mconley) (:⚙️)]

(In reply to Dão Gottwald [:dao] from comment #7)
> http://hg.mozilla.org/projects/ux/rev/f7cb839f3bfc simply predates bug
> 596723, so consumeoutsideclicks="true" was necessary just like for all other
> arrow panels.

I'll be honest and say that it's been too long since I wrote that code to know why I put it there, but I trust Dao's read on the matter.

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/projects/ux/rev/111df3321032

Comment 11

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/111df3321032