934990 - unresolved external symbol in debug builds when calling shadow::Zone::runtimeFromMainThread from browser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Windows-only.  I'm guessing CurrentThreadCanAccessRuntime and CurrentThreadCanAccessZone need to be JS_FRIEND_API rather than extern.  Does that sound right?  I'll confirm that, then put up a patch for review.

UnifiedBindings17.obj : error LNK2001: unresolved external symbol "bool __cdecl js::CurrentThreadCanAccessRuntime(struct JSRuntime *)" (?CurrentThreadCanAccessRuntime@js@@YA_NPAUJSRuntime@@@Z)

(I have a zone sitting around already and I want to go from zone to runtime quickly, so that seemed like the fastest thing.)

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: will you be my JS_FRIEND_API?

This at least builds.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 827454 [details] [diff] [review]
will you be my JS_FRIEND_API?

Review of attachment 827454 [details] [diff] [review]:
-----------------------------------------------------------------

You are quite correct! __declspec(dllexport) r=me

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89b38ee677d2

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/89b38ee677d2

Comment 5

[Andrew McCreight (out of office until 8/21) [:mccr8]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c01cb759b921

Comment 6

[Andrew McCreight (out of office until 8/21) [:mccr8]]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/7822b78fe5aa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/c01cb759b921

Comment 8

[u279076]

I don't think this needs QA verification. If anyone thinks that's a mistake please remove the [qa-] whiteboard tag and add the verifyme keyword.