Closed Bug 935016 Opened 6 years ago Closed 6 years ago

IonMonkey: Specialize string.split(string)

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jandem, Assigned: jandem)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch PatchSplinter Review
str_split calls GetTypeCallerInitObject to get the TypeObject for its result. This is pretty slow because it has to recover the current script and pc.

This patch specializes string.split(string) in Ion so that we can pass the TypeObject directly (and inlining this case also gets rid of other str_split overhead).
Attachment #827405 - Flags: review?(bhackett1024)
Component: JavaScript Engine → JavaScript Engine: JIT
Attachment #827405 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/6e7f8b1e5319
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.