935038 - Danish Localization of Mac platformKeys is broken

Status: RESOLVED FIXED

(Mozilla Localizations :: da / Danish, defect)

Description

[Adam Roach [:abr]]

The file chrome/da/locale/da/global-platform/mac/platformKeys.properties has defined the symbols for Shift, Meta, Alt, and Control to be unicode values 5, 11, 7, and 6, respectively. These are non-rendering control characters, which do not get displayed to the user.

Other platforms use the following values, which correspond to the proper Mac OS glyphs for these functions:

VK_SHIFT=\u21e7
VK_META=\u2318
VK_ALT=\u2325
VK_CONTROL=\u2303

Comment 1

[Adam Roach [:abr]]

Attachment: Fix platformKeys.properties to contain renderable codepoints

Comment 2

[Jesper Kristensen]

Comment on attachment 827443 [details] [diff] [review]
Fix platformKeys.properties to contain renderable codepoints

Kim, I don't remember if toolkit is your or Jakob's

Comment 3

[Kim Ludvigsen]

Jesper:
I'll fix it. They must have been broken for a very long time, I don't remember ever changing them. We should change them in beta too, but I can not do that, as it is not possible for me to clone beta with my current connection. Can you change them in beta?

Comment 4

[Kim Ludvigsen]

Jesper:
I finally succeeded in cloning beta, I'll make the changes.

Comment 5

[Kim Ludvigsen]

I can see that there is a review request. I have no idea what is expected of me. I have changed and pushed the platformkeys in both aurora and beta as mentioned in my earlier comments.

Comment 6

[Adam Roach [:abr]]

(In reply to Kim Ludvigsen from comment #5)
> I can see that there is a review request. I have no idea what is expected of
> me. I have changed and pushed the platformkeys in both aurora and beta as
> mentioned in my earlier comments.

Sorry -- I'm not familiar with the overall process for handling l10n bugs. For code changes, the general flow of things is that one person figures out the fix and puts it up for review as a patch; then a module owner (or someone else familiar with the module) reviews and approves it, at which point it's ready for landing. Based on what's happened with aurora and beta, the process seems less formal for changes to language files.

That said, the da/toolkit/chrome/global-platform/mac/platformKeys.properties file under l10n-central doesn't appear to have been updated, and I don't know what I'm supposed to do to make sure this bug gets fixed there.

Comment 7

[Jesper Kristensen]

Sorry for dropping this. The changes landed here: http://hg.mozilla.org/releases/l10n/mozilla-aurora/da/rev/258c876f9d43 so this is fixed.

l10n-central is unused for most locales, including Danish. I thought these repos were deleted, but apparently they are not. mozilla-aurora is the mainline/master/trunk/whatever it is called.