935041 - Investigate weird failure and re-enable test_sms_add_contact.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

There is a weird failure message in this test (see below) which is probably some kind of Marionette bug.
 


The test case is passing now manually so we should be able to update it to update and re-enable the test.

--------- Stacktrace


TEST-START test_sms_add_contact.py
test_sms_add_contact (test_sms_add_contact.TestSmsAddContact)
Add a contact to a message. ... ERROR
ERROR

======================================================================
ERROR: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zac/.virtualenvs/gaia_ui_0_6_1/local/lib/python2.7/site-packages/marionette_client-0.6.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_add_contact.py", line 32, in test_sms_add_contact
    contacts_app.wait_for_contacts_frame_to_close()
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/apps/contacts/app.py", line 48, in wait_for_contacts_frame_to_close
    self.wait_for_condition(lambda m: not m.find_element(*self._contact_locator).is_displayed())
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 91, in wait_for_condition
    value = method(self.marionette)
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/apps/contacts/app.py", line 48, in <lambda>
    self.wait_for_condition(lambda m: not m.find_element(*self._contact_locator).is_displayed())
  File "/home/zac/.virtualenvs/gaia_ui_0_6_1/local/lib/python2.7/site-packages/marionette_client-0.6.1-py2.7.egg/marionette/marionette.py", line 1100, in find_element
    response = self._send_message('findElement', 'value', **kwargs)
  File "/home/zac/.virtualenvs/gaia_ui_0_6_1/local/lib/python2.7/site-packages/marionette_client-0.6.1-py2.7.egg/marionette/marionette.py", line 577, in _send_message
    self._handle_error(response)
  File "/home/zac/.virtualenvs/gaia_ui_0_6_1/local/lib/python2.7/site-packages/marionette_client-0.6.1-py2.7.egg/marionette/marionette.py", line 639, in _handle_error
    raise MarionetteException(message=response, status=500)
TEST-UNEXPECTED-FAIL | test_sms_add_contact.py test_sms_add_contact.TestSmsAddContact.test_sms_add_contact | MarionetteException: {u'message': u'"toString" is read-only', u'error': u"error occurred while processing 'findElement"}
======================================================================

Comment 1

[Zac C (:zac)]

Attachment: github pr

Would rather enable this test than wait for a Marionette fix

Comment 2

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13392

Pointer to Github pull-request

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 827563 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13392

Version of the fix for v1.2

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 827546 [details] [review]
github pr

LGTM

Comment 5

[Bob Silverberg [:bsilverberg]]

Master fix landed in https://github.com/mozilla-b2g/gaia/commit/5f25972274d4297ca7d4e2f45923301aa77a39e9

Waiting on v1.2 fix

Comment 6

[Florin Strugariu [:Bebe]]

Master:
https://github.com/mozilla-b2g/gaia/commit/5f25972274d4297ca7d4e2f45923301aa77a39e9
V1.2:
https://github.com/mozilla-b2g/gaia/commit/560cc79de9ba8a7bc51593eeec7099f4449b46a0