935089 - Array util methods should support mozilla::Array

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Make ArrayLength, ArrayEnd, and PodArrayZero accept mozilla::Array argument (v1)

This patch makes ArrayLength, ArrayEnd, and PodArrayZero accept mozilla::Array as arguments. A test had to be changed to avoid a name conflict.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 827508 [details] [diff] [review]
Make ArrayLength, ArrayEnd, and PodArrayZero accept mozilla::Array argument (v1)

Review of attachment 827508 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/tests/TestObserverArray.cpp
@@ +8,5 @@
>  #include "nsTObserverArray.h"
>  
>  using namespace mozilla;
>  
> +typedef nsTObserverArray<int> Array_t;

IntArray seems preferable to _t naming.  (I think type names ending with _t might even be reserved in C11 or C++11, can't remember for sure.)

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Make ArrayLength, ArrayEnd, and PodArrayZero accept mozilla::Array argument (v1.1)

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> Comment on attachment 827508 [details] [diff] [review]
> Make ArrayLength, ArrayEnd, and PodArrayZero accept mozilla::Array argument
> (v1)
> 
> Review of attachment 827508 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: xpcom/tests/TestObserverArray.cpp
> @@ +8,5 @@
> >  #include "nsTObserverArray.h"
> >  
> >  using namespace mozilla;
> >  
> > +typedef nsTObserverArray<int> Array_t;
> 
> IntArray seems preferable to _t naming.  (I think type names ending with _t
> might even be reserved in C11 or C++11, can't remember for sure.)

Yeah I like IntArray.

Pushed to
https://hg.mozilla.org/integration/mozilla-inbound/rev/e70c1287741e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e70c1287741e