Closed
Bug 935114
Opened 11 years ago
Closed 11 years ago
Alias `sdk/system` to Node's `OS`
Categories
(Add-on SDK Graveyard :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
|
||
Updated•11 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8357959 -
Flags: review?(evold)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8357959 [details] [review]
GH PR 1337
We should have the functions that are not yet implemented throw an error instead of logging a warning.
The other things I mentioned are just nits.
Attachment #8357959 -
Flags: review?(evold) → review+
|
|
||
Updated•11 years ago
|
Assignee: nobody → jsantell
|
||
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/576c8b2033322497afd252b0ee9e55ecada9d14b
Bug 935114 - Node 'os'
https://github.com/mozilla/addon-sdk/commit/968f6e311c6680cf20af42363e39bcd670c5b601
Merge pull request #1337 from jsantell/node-os
Fixes Bug 935114 - Node 'os', r=@erikvold
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•