935118 - Apply Bug 883814 to master and b2g v1.2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #883814 +++

http video playback fix in Bug 883814 was not applied to master and b2g v1.2 need to apply it.

Comment 1

[Jason Smith [:jsmith]]

Blocks a koi?

Comment 2

[Sotaro Ikeda [:sotaro]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Blocks a koi?

Yes.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Allow buffering to be triggered when we're low on decoded audio or video

Create a patch from Bug 883814.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 827799 [details] [diff] [review]
patch - Allow buffering to be triggered when we're low on decoded audio or video

Review of attachment 827799 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Sorry for dropping this.

Comment 5

[Sotaro Ikeda [:sotaro]]

Bug 911387 blocks youtube video playback confirmation.

Comment 6

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=e142c3c9873e

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> https://tbpl.mozilla.org/?tree=Try&rev=e142c3c9873e

Seems some test failure happening on mac and linux.

Comment 8

[bhavana bajaj [:bajaj]]

:sotaro, what are the next steps here ? Is this expected to be resolved in the next few days or do you need any sort of help here to move forward with the investigation ?

Comment 9

[Sotaro Ikeda [:sotaro]]

I do not think I can fix this bug in this week. Next week, I am going to visit media playback work week in Auckland. I think, I could get some helps there.

Comment 10

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=7f1e0d872960
re-tryserver. This time, there seems no test failure related to media.

Comment 11

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=89c7a27ff9f6
re-try for confirmation.

Comment 12

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #11)
> https://tbpl.mozilla.org/?tree=Try&rev=89c7a27ff9f6
> re-try for confirmation.

Test failure seems not related to media

Comment 13

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=49640a5e3521

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: patch ver2 - Allow buffering to be triggered when we're low on decoded audio or video

Committable patch. Carry "roc review+"

Comment 15

[Sotaro Ikeda [:sotaro]]

In the first tryserver, some tests related to media were failed. But since then all other tryserver tests did not cause test failure related to media. Therefore, it seems not problem to commit the patch.

Comment 16

[Sotaro Ikeda [:sotaro]]

Attachment: patch ver2 for b2gv1.2 - Allow buffering to be triggered when we're low on decoded audio or video

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/aa07aabf4a69

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa07aabf4a69

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/a867f9583cf4