935120 - Alias sdk/events to `events` for node

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Jordan Santell [:jsantell] [@jsantell]]

http://nodejs.org/api/events.html

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: node's event

* Moved `sdk/event/target` to `node/events` -- changed exposed object from `EventTarget` to `EventEmitter`. No deprecation until we're ready.
* Added `removeAllListeners(type)` to EventEmitter. Similar to off(target) and off(target, type).
* Added `listeners(type)` to return listener count
* Added `emitter.emit` return boolean indicating if there were any listeners listening
* Added static method `EventEmitter.listenerCount()`, same as listeners(type)
* Added events 'newListener' and 'removeListener' to be fired upon adding/removing listeners.
* Added alias for `on`: `addListener`
* Node's `setMaxListeners()` was noop'd, but not implemented here -- may incur too much overhead.

All this is for node parity.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8357457 [details] [review]
node's event

It looks like this patch will add `addListener` api to everything that implements EventTarget.  Irakli are you ok with this?

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

For clarity, this will add all of these methods to anything that implements EventTarget (which is alised to node EventEmitter)

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8357457 [details] [review]
node's event

Assuming that Irakli says the api change is alright r+

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 8357457 [details] [review]
node's event

Jordan we had a chat about it on IRC and I had some arguments against this change. This does not means I can't be convinced otherwise, but right now
I'm saying no as I don't see a much value in doing this.

Feel free to followup and convince me I'm wrong if you still disagree.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Nah, we're in agreement -- putting this on hold until we figure out what to do with these node modules

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Unassigning myself from bugs I haven't gotten around to

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562