93521 - Active selections are sometimes grayed out (blurred)

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect, P1)

Description

[Ken]

Steps to reproduce:
1) Run mfcembed.exe.
2) Click and drag on some text to make a selection.  The selected text appears 
with a solid blue highlight on Windows.
3) Press left mouse button down while on a link.
4) While holding down mouse button, drag cursor off of link.
5) Release mouse button (so the link is given tab focus, but not clicked 
through).
6) Now, make a new text selection.

Expected results: the new selection should be given the same highlight as the 
initial selection (solid blue on Windows with default system colors).

Actual results: any new selections made from this point on are gray, indicating 
that a blur event has occured.

What's more, if you hit "tab" then the gray selection becomes solid blue.  But, 
any new selections you make will still be gray.

Comment 1

[saari (gone)]

->0.9.4

Comment 2

[saari (gone)]

Attachment: a little patch to fix this selection behavior

Comment 3

[saari (gone)]

hyatt, bryner, want to review this?

Comment 4

[Brian Ryner (not reading)]

r=bryner (but I'd like to know why this only happens in the aborted
drag-and-drop case)

Comment 5

[Blake Ross]

It happens in plenty of other cases.  For example, go to bugzilla.mozilla.org,
focus the Submit button, and then select text.

Comment 6

[Kathleen :Brade]

saari--you'll remove the tabs before you checkin, right? ;-)

Comment 7

[saari (gone)]

Yeah I'll kill the tabs (gotta go fix that environment), I actually blew away
that tree already :-)

Comment 8

[David Hyatt]

sr=hyatt

Comment 9

[saari (gone)]

Fix checked in on trunk. Baking for the branch.

Comment 10

[saari (gone)]

fixed-on-trunk status whiteboard update

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This seems to have caused regression bug 94823.

Comment 12

[saari (gone)]

Attachment: Okay, this patch is believed to be a far less offensive fix for the problem

Comment 13

[Asa Dotzler [:asa]]

saari, please resolve bugs as Fixed when the fix lands on the trunk. We are not
going to leave bugs open for future branch landings. Thanks.

Comment 14

[Brian Ryner (not reading)]

Please remove the commented out lines you added in nsDocumentViewer, also it
would be good to fix the indentation on the SetContentState() line in ESM if
you're removing the |if|.

I'll give this a go on linux.

Comment 15

[Brian Ryner (not reading)]

I couldn't find any obvious problems with this... (which doesn't mean something
won't come up later).  r=bryner (with my previous comments).

Comment 16

[saari (gone)]

Attachment: changes that bryner pointed out

Comment 17

[David Hyatt]

sr=hyatt

Comment 18

[saari (gone)]

New patch checked in on trunk. Let's try this again.

Comment 19

[Marek Z. Jeziorek]

[e-mail], has it beeen verified on the trunk? If yes, please change
the status whiteboard to verified-on-trunk and let's land on the 0.9.2 branch.

Comment 20

[Michael Dunn]

Tested. Works as expected with 08-15-01 MFCEmbed from trunk

Comment 21

[Ken]

looks good to me too.

Comment 22

[Judson Valeski]

need this on the branch

Comment 23

[saari (gone)]

fix checked into branch

Comment 24

[Blake Ross]

still seeing this in an 8/17 nightly.

Comment 25

[saari (gone)]

Yeah, I screwed up and I suck. I just fixed it on the trunk. Branch when I get 
a build. Bah.

Comment 26

[saari (gone)]

okay, it was fine on the branch, I just screwed up the trunk. all better