935254 - Regression: atk_text_get_text_at_offset implementation broken for list items starting 03 July 2013

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Joanmarie Diggs]

Attachment: test case: list-items.html

Steps to reproduce:
1. Launch Firefox, enable caret navigation (F7), and view the attached test case.
2. Launch the (to be) attached accessible event listener in a terminal window.
3. Click and/or arrow in the first and second list items.

Expected results: Getting the text for caret offset 0 and caret offset 1 for each list item would return the item text (including the bullet) and text offsets reflecting the start and end offsets. i.e.:

Line at offset 0: •Item 1 (0, 7)
Line at offset 1: •Item 1 (0, 7)

Line at offset 0: •Item 2 (0, 7)
Line at offset 1: •Item 2 (0, 7)

Actual results: Depends on the day (see below). But beginning with the 03 July 2013 Nightly Mozilla Central builds, offsets and content are no longer correct. This impacts Orca's ability to provide access to content which has list items.

=================================
Broken Flavor 1: 03-04 July
=================================
Line at offset 0: •Item 1 (0, -1)
Line at offset 1: •Item 1 (0, 7)

Line at offset 0: •Item 2 (0, -1)
Line at offset 1: •Item 2 (0, -1)

=================================
Broken Flavor 2: 05-17 July
=================================
Line at offset 0: • (0, 1)
Line at offset 1: •Item 1 (0, 7)

Line at offset 0: • (0, 1)
Line at offset 1: •Item 2 (0, 7)

=================================
Broken Flavor 3: 18-26 July
=================================
Line at offset 0:  (0, 0)
Line at offset 1: •Item 1 (0, 7)

Line at offset 0:  (0, 0)
Line at offset 1: •Item 2 (0, 7)

=================================
Broken Flavor 4: >= 27 July
=================================
Line at offset 0:  (-1, 0)
Line at offset 1: •Item 1 (0, 7)

Line at offset 0:  (-1, 0)
Line at offset 1: •Item 2 (0, 7)

Comment 1

[Joanmarie Diggs]

Attachment: accessible-event listener

Comment 2

[Trevor Saunders (:tbsaunde)]

I always assumed this was the same issue as bug 880159, but maybe not, anyway it must be fall out of surkov reworking text stuff, so I guess he gets to fix it :)

Comment 3

[Joanmarie Diggs]

(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> I always assumed this was the same issue as bug 880159, but maybe not,
> anyway it must be fall out of surkov reworking text stuff, so I guess he
> gets to fix it :)

I don't think it's the same as bug 880159 because of the broken dates (early July). Is that when he reworked the text stuff?

Comment 4

[Trevor Saunders (:tbsaunde)]

(In reply to Joanmarie Diggs from comment #3)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > I always assumed this was the same issue as bug 880159, but maybe not,
> > anyway it must be fall out of surkov reworking text stuff, so I guess he
> > gets to fix it :)
> 
> I don't think it's the same as bug 880159 because of the broken dates (early
> July). Is that when he reworked the text stuff?

I believe he landed some text stuff around then.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

This is bad.

Comment 6

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 7

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8344810 [details] [diff] [review]
patch

just about as ununderstandable as what it replaces, but we can clean it up later.

Comment 8

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c79871cd01d2

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c79871cd01d2

Comment 10

[Attila Hammer]

This bug only fixed with Firefox 29 series, or have possibility to fix this issue in Firefox 25.0 and 26.0 series?

Attila

Comment 11

[alexander :surkov (:asurkov)]

Comment on attachment 8344810 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 877974
User impact if declined: Orca user rejects to update the Firefox
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): shouldn't make thing worse they were (low risk)
String or IDL/UUID changes made by this patch: no

Comment 12

[alexander :surkov (:asurkov)]

(In reply to Attila Hammer from comment #10)
> This bug only fixed with Firefox 29 series, or have possibility to fix this
> issue in Firefox 25.0 and 26.0 series?

I think no for Firefox 25 since Firefox 26 is out. And it'd be hard to get it into Firefox 26, since only security fixes and such can be taken. I requested uplift to Firefox 28 (aurora) and Firefox 27 (beta).

Comment 13

[Attila Hammer]

Hi Alexander,

Thank you your answer.

Attila

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/453a32531643
https://hg.mozilla.org/releases/mozilla-beta/rev/0cb1744033d0

Comment 15

[u279076]

Joanmarie, this should be fixed now in the latest Firefox 27 (beta), Firefox 28 (aurora), and Firefox 29 (nightly). Can you please confirm?

Comment 16

[Attila Hammer]

Hi Anthony,

I tested this bug yesterday with latest Firefox 27.0 nightly beta.
The bug wonderful resolved with Firefox 27.0.
When I jump a list an article, every longer list item wonderful readable with Arrow keys with Orca, this is previous not working good with Firefox 25.0 and 26.0.

Attila

Comment 17

[u279076]

Thanks Attila. Would you mind also checking Firefox 28 Aurora and Firefox 29 Nightly?

Comment 18

[Attila Hammer]

Hi Anthony,

Both Firefox 28.0 Aurora and latest trunk Firefox 29.0 a1 development release works correct the fix.
When an article jumps a list with l keystroke and read arrow keys a longer list item, Orca wonderful reading the entire list item content, and Orca spokening right the list item simbol (bullet character).
Thank you all awailable releases the committed fix with have possibility to commit this good fix.

Attila

Comment 19

[u279076]

Thanks for your help Attila.