935271 - Fix OSX #ifdefs and remove OS/2 support from gc/Memory.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: fix_memory_cpp-v0.diff

In light of Nick's debugging today, it is pretty clear that the #ifdef XP_UNIX section does not need XP_MACOSX or DARWIN. It's also pretty silly to keep carrying around this OS/2 code when nobody has any idea if it still works.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 827680 [details] [diff] [review]
fix_memory_cpp-v0.diff

Review of attachment 827680 [details] [diff] [review]:
-----------------------------------------------------------------

Let's keep the OS/2 support. It looks like people are maybe still using it.

Comment 2

[Terrence Cole [:terrence]]

Specifically, I did not realize that there is an ESR17 build for OS/2. This would have been after I moved stuff around in Memory.cpp. As we haven't had any OS/2 bugs, I expect those changes, surprisingly, did not break anything.

https://hg.mozilla.org/integration/mozilla-inbound/rev/eaaa99f26c6b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eaaa99f26c6b