935291 - Request types that prompt when the saved permission is UNKNOWN do not work.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Prompt in those cases as well

Looks like bug 853356 regressed this.

STR: open https://people.mozilla.org/~rmorais/na.html in the Browser app. No prompt is shown.

What happens is that handleExistingPermission() checks if the request is DENY or UNKNOWN and it's *not* a case that should prompt for unknown, in order to cancel the request right away. It doesn't do anything when the request *is* a case that should prompt for unknown, leaving the request type untouched, and then back in prompt() we filter away requests that have type != PROMPT.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: request-prompt-fix.patch

I also found the same problem while I writing patch for bug 898949. Here is my discovery and proposal:
1. Browser app will return UNKNOWN for these permission, we can simply transfer them into PROMPT before doing any examination.
2. For aggregated permission such as video/audio capturing, the deny field is not correctly set for every permission request. Therefore, the second permission request will be filter out by http://mxr.mozilla.org/mozilla-central/source/b2g/components/ContentPermissionPrompt.js#249 . We need to ensure every permission request is examined in handledByApp().

Comment 2

[[:fabrice] Fabrice Desré]

Shouldn't we wait for bug 853356 to be fix properly?

Comment 3

[Reuben Morais [:reuben]]

Yea, now that bug 853356 was backed out this should probably be fixed there.

Comment 4

[Alfredo Yang (:alfredo)]

Bug 951997, testcase for this bug.