935350 - Rename 'keyboard' role in homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #915570 +++

I made a mistake in the cloned bug -- the 'keyboard' role should be changed in home screen app.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Patch to come.

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#13410

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 827796 [details] [review]
mozilla-b2g:master PR#13410

r=me.

I did not notice this either.
Thanks for fixing this up.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/c367635134a18ba98e2f9267d0c70da7542239ba

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This should be koi+.

Comment 6

[William Hsu [:whsu]]

I will verify it later.
Thanks!

--------- Needinfo myself ---------

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 c367635134a18ba98e2f9267d0c70da7542239ba
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.2: 938e2a276b79f20cac14afde0fd05843a1f6fcdc

Comment 9

[William Hsu [:whsu]]

Thanks for your help!
I verified it. The home screen doesn't have IME icon.

* Test Build:
 - Gaia:     3cc5e6ddec0656b3a6a197e989dabebee536c982
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/ef65864c10e6
 - BuildID   20131110004003
 - Version   26.0